thats how it is right?
# pinot-devk
Kishore G
09/06/2021, 5:14 PM
thats how it is right?
k
Ken Krugler
09/06/2021, 5:16 PMYou do use slf4j, but (for example) the pinot-spi pom has:
Copy code
<dependency>
<groupId>org.apache.logging.log4j</groupId>
<artifactId>log4j-slf4j-impl</artifactId>
</dependency>Ken Krugler
09/06/2021, 5:20 PMYou could also remove a number of log4j entries from the dependency management section of the top-level pom.xml, as once you have a dependency on
log4j-slf4j-implKen Krugler
09/06/2021, 5:22 PMOther than that, the following project pom.xml files should probably be modified to remove log4j dependencies:
Copy code
pinot-spi
pinot-commonKen Krugler
09/06/2021, 5:24 PMI think these are what’s causing the plugins to pull in log4j classes
Ken Krugler
09/06/2021, 5:25 PMYou’d have to add in log4j dependencies to the server/broker/controller projects
k
Kishore G
09/06/2021, 6:29 PM
makes sense, I dont see any reason for not doing that
Kishore G
09/06/2021, 6:30 PM
may be tools as well
k
Ken Krugler
09/06/2021, 8:13 PMRight, tools would want to include the
log4j-slf4j-impl