https://pinot.apache.org/ logo
#pinot-dev
Title
# pinot-dev
k

Kishore G

09/06/2021, 5:14 PM
thats how it is right?
k

Ken Krugler

09/06/2021, 5:16 PM
You do use slf4j, but (for example) the pinot-spi pom has:
Copy code
<dependency>
      <groupId>org.apache.logging.log4j</groupId>
      <artifactId>log4j-slf4j-impl</artifactId>
    </dependency>
So this pulls in the log4j implementation.
You could also remove a number of log4j entries from the dependency management section of the top-level pom.xml, as once you have a dependency on
log4j-slf4j-impl
, that pulls in log4j-core and log4j-api, etc.
Other than that, the following project pom.xml files should probably be modified to remove log4j dependencies:
Copy code
pinot-spi
pinot-common
I think these are what’s causing the plugins to pull in log4j classes
You’d have to add in log4j dependencies to the server/broker/controller projects
k

Kishore G

09/06/2021, 6:29 PM
makes sense, I dont see any reason for not doing that
may be tools as well
k

Ken Krugler

09/06/2021, 8:13 PM
Right, tools would want to include the
log4j-slf4j-impl
dependency