Folks, I need some help. My latest PR adds JMH ben...
# pinot-deva
Atri Sharma
09/15/2021, 4:20 AMFolks, I need some help. My latest PR adds JMH benchmarks, hence generates relevant classes. However, Pre commit is failing for the same with checkstyle failures. I thought checkstyle is excluded for /target?
https://github.com/apache/pinot/pull/7405/checks?check_run_id=3595648311
x
Xiang Fu
09/15/2021, 4:38 AM
have you tried this compatible verifier script from your local?
Xiang Fu
09/15/2021, 4:38 AM
you can try to exclude those paths from the pom
a
Atri Sharma
09/15/2021, 4:39 AMYes, and strangely, it passes for me
x
Xiang Fu
09/15/2021, 4:39 AM
you can add some exclude in config/checkstyle.xml
a
Atri Sharma
09/15/2021, 4:39 AMThat. is what is confusing, I thought. it is already excluded
x
Xiang Fu
09/15/2021, 4:39 AM
actually it’s
config/suppressions.xmla
Atri Sharma
09/15/2021, 4:40 AMLet me take a loo, thanks!
x
Xiang Fu
09/15/2021, 4:41 AM
exclude
target/generated-test-sourcesXiang Fu
09/15/2021, 4:41 AM
right now we only exclude
Copy code
<!-- Suppress autogenerated parser files -->
<suppress checks=".*" files="target/generated-sources"/>a
Atri Sharma
09/15/2021, 4:42 AMAh yes, my bad. I somehow misread as a complete exclusion of target folder
Atri Sharma
09/15/2021, 4:42 AMwhich, btw, is what we should be doing?
x
Xiang Fu
09/15/2021, 4:46 AM
I think it’s fine to exclude
targeta
Atri Sharma
09/15/2021, 4:46 AMOk, let me add a separate PR for it, thanks for the help!