https://pinot.apache.org/ logo
#general
Title
# general
a

Adrian Cole

08/26/2020, 4:44 AM
Hi, question about ServiceManager.. is it a feature or bug to have multiple instances of the same role in bootstrap services? eg. 2 minions
would be easier to manage the orchestration code, if we can assume one per role
k

Kishore G

08/26/2020, 5:20 AM
Although Helix definitely allows multiple instances of same roles within the same process, I don’t see the need for that feature apart from testing purposes - eg simulate a cluster within a single process
a

Adrian Cole

08/26/2020, 5:24 AM
so feature then? 😄
it forces things slightly more complex, need multimap instead of map
k

Kishore G

08/26/2020, 5:31 AM
It’s ok to have that restriction for now.
👍 1
a

Adrian Cole

08/26/2020, 5:31 AM
SGTM
x

Xiang Fu

08/26/2020, 5:48 AM
when I first wrote that, I loose the restrictions to allow any number of pinot-roles. It’s ok to assume 1 controller/broker/server, for minions I suspect it could be many? In general I tried to use instance_id which is in the format of
[role]_[hostname]_[port]
a

Adrian Cole

08/26/2020, 5:48 AM
luckily intellij saves history 😄
x

Xiang Fu

08/26/2020, 5:49 AM
👍
a

Adrian Cole

08/26/2020, 5:49 AM
@Xiang Fu where are you physically btw? I'm in malaysia
x

Xiang Fu

08/26/2020, 5:55 AM
i’m in bay area
pacific time zone
a

Adrian Cole

08/26/2020, 5:57 AM
ah ok so late working
x

Xiang Fu

08/26/2020, 5:58 AM
🙂
a

Adrian Cole

08/26/2020, 6:48 AM
on my PR one interesting thing I notice is logs clobbering themselves now
Copy code
Starting Pinot Service Managerols.admin.PinotAdministrator.main(PinotAdministrator.java:162) [classes/:?]
WARNING: sun.reflect.Reflection.getCallerClass is not supported. This will impact performance.eManager_a45156d5b660_7098
06:43:30,546 ERROR [main] zk.ZKHelixManager (ZKHelixManager.java:704) - fail to createClient.s
you can see logs clashing on the first line
x

Xiang Fu

08/26/2020, 7:11 AM
logs clashing?
a

Adrian Cole

08/26/2020, 7:12 AM
'Starting Pinot Service Managerols.admin.PinotAdministrator.main'
x

Xiang Fu

08/26/2020, 7:12 AM
ah
a

Adrian Cole

08/26/2020, 7:12 AM
but this might be something docker related so don't worry about it for now
I'm testing my PR now
this was because stdout/stderr
not about pinot
x

Xiang Fu

08/26/2020, 7:14 AM
right
logger itself should be fine
a

Adrian Cole

08/26/2020, 7:21 AM
is pinot java 1.8+?
x

Xiang Fu

08/26/2020, 7:22 AM
yes
a

Adrian Cole

08/26/2020, 7:22 AM
I want to log time spent servicemanager startup as there is also time lost there
the dag is sm -> c -> [b,s]
x

Xiang Fu

08/26/2020, 7:44 AM
yes
also the container log should have timestamp with it