:wave: Hi y’all, I’m taking the day off work to v...
# generalg
Grant Sherrick
10/22/2021, 3:02 PM👋 Hi y’all, I’m taking the day off work to volunteer on pinot. I mostly work on streaming data related tasks day to day, would it be reasonable if I gave implementing a
KafkaThriftMessageDecoder👋 1
k
Kishore G
10/22/2021, 3:57 PM
thats amazing Grant!
Kishore G
10/22/2021, 3:58 PM
go for it, I think protobuf is also another one that users have asked for
Kishore G
10/22/2021, 3:58 PM
feel free to ping us if you need any guidance/help
g
Grant Sherrick
10/22/2021, 4:05 PMSounds good! We use a bit of protobuf around here. Now that it’s included in the schema registry, I am sure that it’s not too far off from how the KafkaAvroMessageDecoder works right now
k
Kishore G
10/22/2021, 4:05 PM
right.
g
Grant Sherrick
10/22/2021, 4:06 PMI’ll start with thrift and keep y’all up to date with how it’s going. There’s no JIRA or any other work tracker for this project, right?
k
Kishore G
10/22/2021, 4:07 PM
there is, we use github
🙏 1
Kishore G
10/22/2021, 4:08 PM
Kishore G
10/22/2021, 4:08 PM
this was the record reader but that only works for batch ingestion
g
Grant Sherrick
10/22/2021, 9:52 PMOkay, I’ve got a first pass here. I won’t have time to finish it up today, but I’ll give it some more polish in a few weeks: https://github.com/apache/pinot/pull/7620/files
k
Kishore G
10/23/2021, 4:34 PM
Thanks @User. that was quick. Did a quick review. It looks good, add the test case and we should be able to get the V0 merged