I have a few changes to support MSE adaptive routi...
# pinot-dev
t
I have a few changes to support MSE adaptive routing. • Add latency tracking for MSE adaptive routing • Make adaptive routing variables runtime adjustable • [#12507] Implement adaptive pool selection for StrictReplicaGroupInstanceSelector - fixes correctness bugs with SSE adaptive routing + upsert tables @Jia Guo / @Sidd / @Vivek Iyer Vaidyanathan / @Xiang Fu can you TAL at these? They've been deployed on Stripe's clusters for a few weeks / months and working well.
👀 1
m
cc @Gonzalo Ortiz @Yash Mayya
t
@Xiang Fu @Gonzalo Ortiz @Yash Mayya are any of you able to take a look at these?
g
I didn’t. I’ll take a look this week
t
Hey @Gonzalo Ortiz, I've addressed your comments on [#12507] Implement adaptive pool selection for StrictReplicaGroupInstanceSelector, do you have any other thoughts?
g
I missed the message and it is getting late in EU. I’m going to review that early next week
thanks 1
Hi Tim! I’ve approved the PR and added some comments. ANyway, we need to resolve some conflicts
I’ll merge the PR as soon as the merge is fixed. The comments are probably not that problematic.
t
Thanks for the review! I rebased and addressed most of the comments (the merge conflicts were simple, and my latest changes are in the last 3 commits).
Do you think you can help me get github.com/apache/pinot/pull/18791 reviewed next? In it's current state it's being tested at Stripe's scale, but as the base drifts away from what Stripe is running it'll get harder to re-test.