Hi Team, Can I add a sidecar container to pinot co...
# general
m
Hi Team, Can I add a sidecar container to pinot controller and broker pods when deploying using the helm chart?
Ok I see that it is missing in the templates.. so I am planning to add it there. would that be ok for you? Do I need also to open an issue before creating a PR?
@Mayank & @Xiang Fu, so I created https://github.com/apache/pinot/issues/16880 but I am not able to add labels to the issue. I think I need to add
PEP-Request
as per the guidelines.
x
sounds good, feel free to create the PR
m
@Xiang Fu, It seems that k8s has a new feature to use initContainer section to create sidecars. The feature is GA since k8s v1.33 but available since v1.28 and enabled by default since v1.29. Since we Pinot helm chart exposed initContainers, I have adviced our team to use that, and there is no need to introduce a new sidecar section in the chart. I suggest to close this PR. I will write a comment in the PR as well.
x
agreed
we also internally use initContainer to set sidecar / auth etc