Hello, when running the following Presto query on ...
# troubleshootingn
Nizar Hejazi
09/28/2022, 8:26 PMHello, when running the following Presto query on top of Presto-Pinot-connector:
SELECT id FROM role_with_company WHERE (isPartialAdmin IS NULL)=true AND company='{company_id}'company_idjava.lang.IndexOutOfBoundsException Copy code
PrestoExternalError(type=EXTERNAL, name=PINOT_EXCEPTION, message="Query SELECT "id" FROM role_with_company WHERE (("company" = {company_id}) AND (("isPartialAdmin" IS NULL) = true)) LIMIT 100000 encountered exception {"message":"QueryExecutionError:\njava.lang.IndexOutOfBoundsException\n\tat java.base/java.nio.Buffer.checkIndex(Buffer.java:687)\n\tat java.base/java.nio.DirectCharBufferU.get(DirectCharBufferU.java:269)\n\tat org.roaringbitmap.buffer.MappeableArrayContainerCharIterator.nextAsInt(MappeableArrayContainer.java:1876)\n\tat org.roaringbitmap.buffer.ImmutableRoaringBitmap$ImmutableRoaringIntIterator.next(ImmutableRoaringBitmap.java:113)","errorCode":200} with pinot query "SELECT "id" FROM role_with_company WHERE (("company" = {company_id}) AND (("isPartialAdmin" IS NULL) = true)) LIMIT 100000"", query_id=20220928_202056_30456_i2zba)👀 1
Nizar Hejazi
09/28/2022, 8:29 PMWe run Pinot 0.10 version (ST v0.4)
m
Mayank
09/28/2022, 8:30 PM
Seems like related to null support.
r
RachelP
09/28/2022, 8:30 PMDoes the query run directly on Pinot?
n
Nizar Hejazi
09/28/2022, 8:32 PM@Mayank if you are referring to proper null support outside filter predicate, this is not enabled for these queries (this is v0.10)
m
Mayank
09/28/2022, 8:34 PM
isPartialAdmin IS NULLn
Nizar Hejazi
09/28/2022, 8:40 PMyes
m
Mayank
09/28/2022, 8:42 PM
That null vector is a RoarringBitMap. So I am suspecting something went wrong there to lead to IndexOutOfBound. (speculation)
n
Nizar Hejazi
09/28/2022, 8:51 PM@Jackie ^
j
Jackie
09/28/2022, 9:06 PMThe exception is thrown from RoaringBitmap library
Jackie
09/28/2022, 9:06 PMDo you encounter the same exception if doing
SELECT id FROM role_with_company WHERE isPartialAdmin IS NULL AND company='{company_id}'n
Nizar Hejazi
09/28/2022, 9:21 PMit works
Nizar Hejazi
09/28/2022, 9:22 PMdo you know if this issue is potentially fixed in Pinot 0.11 or still need to get fixed?
j
Jackie
09/28/2022, 9:35 PMI think it should be fixed in 0.11 as we added
IsNullTransformFunctionthankyou 1
Jackie
09/28/2022, 9:37 PMBut again, you should avoid writing the query this way because it will be solved as an EQUAL predicate over an expression, which is more expensive than directly solving the IS_NULL predicate
Jackie
09/28/2022, 9:37 PMWe should consider auto-rewrite it though
n
Nizar Hejazi
09/28/2022, 9:38 PMIt is a bit complicated since we translate from a domain-specific query language to SQL automatically, but we plan to look into specializing this logic path.