Hi Team , Can someone review this : <https://githu...
# pinot-deva
Anand Kr Shaw
09/09/2024, 1:43 AMHi Team , Can someone review this : https://github.com/apache/pinot/pull/13954
cc: @Kishore G @Mayank
Anand Kr Shaw
09/09/2024, 5:44 AMCan we auto-enable the workflow runs on PR update ?
It becomes a bottleneck to ask for approvals to again run the workflow on an existing PR.
Anand Kr Shaw
09/10/2024, 5:09 AM@Jackie
Fixed your comment : https://github.com/apache/pinot/pull/13954
Anand Kr Shaw
09/10/2024, 4:17 PM@Jackie @Mayank
Fixed the review comments - Looks like to me that some flanky tests are failing.
m
Mayank
09/10/2024, 7:51 PM
Merged
j
Jackie
09/10/2024, 8:23 PMActually I still have some comments unaddressed. They are not critical, but would be good if we can address them in a separate PR.
m
Mayank
09/10/2024, 9:56 PM
Oh, sorry, I just saw the approval from Jackie so merged. Yeah, let's get those addressed @Anand Kr Shaw
Mayank
09/10/2024, 9:57 PM
Since it won't be your first PR anymore, no more babysitting needed to restart workflow.
a
Anand Kr Shaw
09/11/2024, 1:47 AMyay ! thanks @Jackie will take care of that !
Anand Kr Shaw
09/14/2024, 2:39 PMfollow up PR : https://github.com/apache/pinot/pull/14000
cc: @Mayank @Jackie
👍 1
x
Xiang Fu
09/14/2024, 3:42 PM
Can you fix the lint
ack 1
a
Anand Kr Shaw
09/14/2024, 4:48 PMDone @Xiang Fu