wave Hello folks Currently I am working on this <https gith Apache Pinot #troubleshooting

Join Slack

:wave: Hello folks, Currently, I am working on thi...

# troubleshooting

Tanmesh Mishra

08/09/2022, 2:19 AM

👋 Hello folks, Currently, I am working on this issue and need some help in generating thrift sources 🧵

Tanmesh Mishra

08/09/2022, 2:23 AM

based on the investigation, I need to add Interval Qualifier to the ExpressionType and for this I need to update

query.thrift

file. After updating the

query.thrift

file, the java source for the thrift file is not generating when I am running

mvn clean install -DskipTests -Dcheckstyle.skip -Dlicense.skip=true

. I believe that the java source for the thrift file should be generated when the entire package is being build as there is a pom build rule defined here. Is there any other command I can run to generate java source for thrift files?

Mayank

08/09/2022, 2:25 AM

You might have to generate the Java file via standalone thrift and then commit the new file. It could be made part of the build I guess

Tanmesh Mishra

08/09/2022, 2:32 PM

Thanks Mayank! yeah, I went ahead and manually generated the java files

Tanmesh Mishra

08/10/2022, 2:12 AM

Here is the PR for this change: https://github.com/apache/pinot/pull/9184 , what is the process to ask for the code review? I am not able to request review from the PR.

Tanmesh Mishra

08/10/2022, 2:13 AM

@Mayank perhaps can you help with the review? 🙂

Mayank

08/10/2022, 2:24 AM

Hey @Tanmesh Mishra thanks Will review

👍 1

Mayank

08/10/2022, 3:09 AM

I have added @Jackie as reviewer also

🙇 1

Open in Slack

Previous Next