I’m implementing similar semantics to S3PinotFS and in a unit test noticed that normalizeToDirectoryUri() might contain a bug. That line, when just testing this like:

URI foo = new URI("foo", "my-host", "data/dir_2/", null);

results in:

java.net.URISyntaxException: Relative path in absolute URI: <foo://my-hostdata/dir_2/>

In my code I replaced this with:

return new URI(uri.getScheme(), uri.getHost(), DELIMITER + sanitizePath(uri.getPath() + DELIMITER), null);

This code is only used by

copyDir

, which is used in

copy

of PinotFS, and

doMove

, which in turn is used by

move

of

BasePinotFS

Thanks Gerrit. Please submit a PR and we will review it