Hi, When do we usually release a new helm chart version? There are new changes for the helm chart recently merged to master branch. I need to deploy these new changes but I would rather want to deploy helm chart from version tag rather from the master branch directly.

I was thinking the same we should release the newer version of the pinot helm chart. I can work on this.

Thanks @Abhishek Sharma . Looking forward for it 🙂

Here is the PR as well 🙂

whenever we need to release helm 🙂 Ideally we can release every related helm commit / But I also hear maybe we can align the helm version with pinot release version.

may be we can automate the helm release ?

The downside I see with aligning helm release with Pinot release is that Pinot is getting a new version every six months. So, if there is a major fix in helm chart due to a new k8s update for example, we have to wait for six months for a new release. I prefer the idea of releasing frequently as new changes are merged

I think we can release patch version of chart with every commit to helm. for eg.

1.1.0

,

1.1.1

...

1.1.n

. When we will release newer version of pinot (say 1.2 version), helm release would be

1.2.0

and continue the change in patch version. wdyt ?

Yes, that can be a good approach. So only major and minor version of the chart matches with pinot release but the patch versions would be different. We are now at 0.2.8. So bumping it to 1.1.0 would do the trick.

One thing, I would like to mention. IF we are aligning the helm chart release based on pinot release, we should mention image tag in values same as of pinot release version instead of

latest

. From PR perspective, I will make a change if @Xiang Fu / others feels comfortable with the above mentioned approach. Thanks

I think for the master branch we can still keep latest image, just when we plan to release, we can fix an image tag

Hi @Abhishek Sharma Could you please check here? https://github.com/apache/pinot/pull/13165#issuecomment-2137872028 I tried to deploy version 0.2.9 but helm wasn’t able to render it. You need to add space between : and { at two places. I found this error after an hour of debugging

right, I can reproduce the issue. I did run the helm template for the changes but both part missed from the testing because of the default

false

in values.yaml. raising the PR for fix with updated helm 0.29 zip. sorry for inconvenience.

Thanks @Abhishek Sharma Good news : The probes are now rendering fine. Bad news : I am gonna bother you with two more issues. 🤓 1) There is extra # in pdb file so the apiversion is getting commented out in the template. https://github.com/apache/pinot/blob/49d1af0317d9a558886b55c7f0e646e67b589a7a/helm/pinot/templates/broker/poddisruptionbudget.yaml#L18

# Source: pinot/templates/controller/poddisruptionbudget.yaml
#
# Licensed to the Apache Software Foundation (ASF) under one
# or more contributor license agreements.  See the NOTICE file
# distributed with this work for additional information
# regarding copyright ownership.  The ASF licenses this file
# to you under the Apache License, Version 2.0 (the
# "License"); you may not use this file except in compliance
# with the License.  You may obtain a copy of the License at
#
#   http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing,
# software distributed under the License is distributed on an
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
# KIND, either express or implied.  See the License for the
# specific language governing permissions and limitations
# under the License.
#apiVersion: policy/v1
kind: PodDisruptionBudget
metadata:
  name: release-name-pinot-controller
spec:
  maxUnavailable: 1
  selector:
    app: pinot
    release: release-name
    component: controller

2) When this automaticReload is enabled, I am getting the following error:

Error: YAML parse error on pinot/templates/controller/statefulset.yaml: error converting YAML to JSON: yaml: line 56: mapping values are not allowed in this context

Okay. I'll try to fix them in sometime. Thanks for mentioning.