Calculated first report on top of Apache Pinot :pa...
# general
j
Calculated first report on top of Apache Pinot 🦜
🎉 3
x
Wow! Amazing!!
j
SUM also works if report is sliced by a dimension (added CAST to DOUBLE). But SUM by empty dim does not work, I mentioned you in another thread asking for help 😉
x
Ack, did you log all the queries/responses? Also do you want to submit a PR for existing changes for JDBC as well?
j
We log everything, I can share any logs with you. Regarding JDBC: You created a PR and mentioned it in a different thread, where I asked for rights to add a commit to your PR. Let me know if you prefer adding commit to your PR or if I should take your branch, add a commit and create my own PR.
💥 1
x
Feel free to commit and create a new PR 🙂
j
I tried to rebase the result with upstream master and there is a conflict, see the screenshot. May I kindly ask you for resolving the conflict because it is in your changes?
t
Wow, Jan, I step away for a company meeting, and all this happens. Super cool!
j
@Xiang Fu are you going to resolve the conflict or should I give it try?
x
let me resolve it first
done
you can also push more commit to this branch, I grant you access
j
https://github.com/apache/pinot/pull/12480 Can you review/merge it or should I ask anybody else?
x
I can, let me take it in a pass and also check the CI pipeline
👍🏼 1
j
@Xiang Fu can you estimate when the above change we merged will be released?
x
I think this is already fixed and should be included in 1.1.0 release
j
Cool, will try
I specified 1.1.0-shaded in my Gradle file. I tried to scan metadata through JDBC and it returns
java.sql.SQLFeatureNotSupportedException
again. Can you please double check that the fix we delivered is included in 1.1.0? If not, can you estimate when a next version will be released?
x
do you know which method it’s calling ?
if you are not looking for pinot released versions, then you can push your own branch then build it using jitpack(https://jitpack.io/#apache/pinot)
j
It fails in
org.apache.pinot.client.base.AbstractBaseConnection.setTransactionIsolation
.
But with 1.1.0 from Maven it is still failing. I checkout branch release-1.1.0. I searched for my commit from our PR: 33258cabecb33514ce9dd208e908214eb93eb547 It is not there. Can you estimate when it could be officially released? I cannot released a custom build to our production env.
x
In general the release cadence is every 4-6 month. That’s why I suggest to publish your own release.
Or maybe you want to try the other repositories? Like LinkedIn has published weekly on maven as well.
j
I can't find any LinkeIn artifacts in Maven. Can you guide me, please?
here
j
wow, they release almost every day! Will try it, thanks!
Before I had to use "shaded" version. Is this LinkeIn version also shaded?
x
better to download and check. If the jar file has shaded in the name then it’s a shaded jar
j
It seems that it does have shaded in this name: https://mvnrepository.com/artifact/org.apache.pinot/pinot-jdbc-client/1.2.0-dev-1333 I try it
Hm, it does not work, because it tries to download the driver from this path: https://repo.maven.apache.org/maven2/org/apache/pinot/pinot-jdbc-client/1.2.0 But it does not exist, there are only versions up to 1.1.0. Not sure how to configure Gradle to download the 1.2.0 version from maven central.
Hm...it does not work for me 😞 > Could not resolve org.apache.pinotpinot jdbc client1.2.0-dev-1333. > Could not get resource 'https://linkedin.jfrog.io/ui/native/open-source/org/apache/pinot/pinot-jdbc-client/1.2.0-dev-1333/pinot-jdbc-client-1.2.0-dev-1333.pom'. > Could not HEAD 'https://linkedin.jfrog.io/ui/native/open-source/org/apache/pinot/pinot-jdbc-client/1.2.0-dev-1333/pinot-jdbc-client-1.2.0-dev-1333.pom'. Received status code 403 from server: Forbidden
x
I think those are public
there are shaded jars there as well
try to configure linkedin repo : https://linkedin.jfrog.io/artifactory/open-source
you don’t need to put
/ui/native
, that is for ui access
e.g.
Copy code
wget <https://linkedin.jfrog.io/artifactory/open-source/org/apache/pinot/pinot-jdbc-client/1.2.0-dev-1333/pinot-jdbc-client-1.2.0-dev-1333.pom>
works for me
j
works, thanks! The download is very slow, but hopefully we can live with that...
👍 1
OK, it does not work, 1.2.0 is not compatible with our Kotlin Springboot stack (conflicts). Finally I succeeded with LinkedIn version
1.1.0-dev-1284
(contains my fix) and WITHOUT
shaded
! Thanks for all your help! Now I can push it to production (with limited functionality, described in other threads).
x
nice! it’s good that you can have a close to master version code to use 🙂
We can patch more to make the jdbc client working better