Hi team, I'm investigating the issue <11639> . Tur...
# pinot-dev
t
Hi team, I'm investigating the issue 11639 . Turned out it is not because of the hyphen
-
in the table name but because of the number as the first character in the table name (see the picture below) being numeric instead of alphabetical. The hyphen issue has been fixed in the PR earlier I'm trying to see where should I make the changes as the error points out to
target/generated-sources/javacc/org/apache/pinot/sql/parsers/parser/SqlParserImpl.java
which is auto-generated by the file
src/main/codegen/includes/parserImpls.ftl
. However, I'm not sure how to generate
SqlParserImpl.java
from
.ftl
template file. Could you give me some pointers on this ?
@Rong R when you are free, could you help me take a look at the question?
r
i dont think we should support beginning with number, see https://www.postgresql.org/docs/current/sql-syntax-lexical.html#SQL-SYNTAX-IDENTIFIERS
t
I see. Thanks for the reference. I will update the issue thread accordingly
However, I'm not sure how to generate
SqlParserImpl.java
from
.ftl
template file. Could you give me some pointers on this ?
Could you help me with this as well? This is more for my curiosity and understanding as you might be the best person to ask from your PR https://github.com/apache/pinot/pull/8484
r
use
mvn package
will auto gen the SqlParserImpl.java
dont do intellij it doesn't invoke the plugin to regenerate the file
😂 1