Hi @Xiang Fu, I'm working on the PR Add GENERATE_ARRAY function #11786 . Could you help to point out to where I could find the code for the existing function

ARRAY[x, y, z]

. I'm trying to find it in both the code and in the documentation but could not find 🤔

Pinot supports ARRAY[x, y, z] syntax to manually craft an array literal. This is good for small scale, and in real prod, we need to add an ARRAY function to generate an ARRAY sequence for a given range.

Similar to the GENERATE_ARRAY function in Google BQ

You can check

org.apache.pinot.core.operator.transform.function.ArrayLiteralTransformFunction

for leaf transform function. Then you also need to add a scalar function in

org.apache.pinot.common.function.scalar.ArrayFunctions

Last thing is to register it here: https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java#L259

Thanks for the reply Xiang Fu. • Is this something like this to be added in

org.apache.pinot.common.function.scalar.ArrayFunctions

the detail is in the screenshot I sent below • I see a similar example with

arrayConcatLong

(doc) in the same file

ArrayFunctions

being registered by the decorator

@ScalarFunction

in pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java. However, it is not registered in https://github.com/apache/pinot/blob/master/pinot-common/src/main/java/org/apache/pinot/common/function/TransformFunctionType.java#L259 like you mentioned above so I'm abit confused with what's next though

The annotation @scalar will register the function as a scalar function. If the transform function is not implemented, then pinot will fallback to Scalar function. The perf of scalar function is not as good as Transform function implementation. Scalar function is row by row, Transform function is in batch

Thanks. Let me implement the batch transformation one 🙏

It’s looking for a scalar function named:

arrayGenerate

in

pinot-common/src/main/java/org/apache/pinot/common/function/scalar/ArrayFunctions.java