Do we know if we need to tag a minion host with so...
# pinot-dev
p
Do we know if we need to tag a minion host with some tenant or not? I see our minion host as
minion_untagged
but i find no documentation around how tagging it will be used.
j
No I do not think its needed to tag a Minion.
p
Thanks @Jayesh Asrani Is there a way to isolate minion jobs similar to broker/server tenancy? If i can give a minionTenant and all the tables jobs will go to those specific minions.
j
I am not aware of it. @Mayank Does tagging the minion work in a similar way to server/broker?
m
@Pratik Tibrewal what’s the problem beyond isolation you are trying to solve?
p
hey @Mayank it's around isolation and also cost attribution aspect that you are looking into. We want to attribute the cost of minion nodes to the customers whose tables are being processed by the specific tagged minion nodes.
m
Cost can be computed by associating tasks to tables? What kind of issues are you seeing that need isolation? Perhaps what we need here is some fair or controllable scheduling. There isn’t a plan yet but you can file a GH issue.
p
Cost can be computed by associating tasks to tables?
Hmm we can try this and prorate based on task-level metrics maybe.
What kind of issues are you seeing that need isolation?
We are not seeing any issues as such but we wanted to isolate minions jobs across tiers atleast in our case.
Perhaps what we need here is some fair or controllable scheduling. There isn’t a plan yet but you can file a GH issue.
Sure let me file one.
s
@Pratik Tibrewal - Hi 👋 Was just curious to know if you ended up filing a GH issue for scheduling tasks on specific minions, based on the tags. Can you point me to the issue if you've created one? Thanks!
p
s
Thanks @Pratik Tibrewal. Just curious, if adding
minionInstanceTag
to the task's config is verified to work correctly. I skimmed through the code and felt, the per task config is not really honored, and the default minion instance tag seems to be set to `minion_untagged`: https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apa[…]controller/helix/core/minion/PinotHelixTaskResourceManager.java Am I missing something there?
But do give it a try and let me know if it works or not! Going through the code, it should work!
s
I see. Thanks. We’re running scheduled tasks. Will try an adhoc task.