https://pinot.apache.org/ logo
b

balci

12/18/2020, 9:12 PM
Hi folks. I’m trying to debug this github-actions failure in my PR. It seems like mvn testCompile is failing when compiling one of my tests, because it cannot find a symbol from a dependency package (pinot-spi):
Copy code
Error:  COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
Error:  /home/runner/work/incubator-pinot/incubator-pinot/pinot-core/src/test/java/org/apache/pinot/core/util/TableConfigUtilsTest.java:[450,45] cannot find symbol
  symbol:   variable BATCH_TYPE
  location: class org.apache.pinot.spi.ingestion.batch.BatchConfigProperties
Error:  /home/runner/work/incubator-pinot/incubator-pinot/pinot-core/src/test/java/org/apache/pinot/core/util/TableConfigUtilsTest.java:[452,35] cannot find symbol
  symbol:   method constructBatchProperty(java.lang.String,java.lang.String)
  location: class org.apache.pinot.spi.ingestion.batch.BatchConfigProperties
...
It is interesting because the test I added is almost a copy of an existing test case using same symbols (ingestionBatchConfigTest). Does anyone have any insight into what might have gone wrong? @Neha Pawar I noticed you added the test ‘ingestionBatchConfigsTest’ recently, curious if you had a similar issue. Thanks.
x

Xiang Fu

12/18/2020, 9:13 PM
can you try to rebase to origin master?
b

balci

12/18/2020, 9:13 PM
sure, let me try
x

Xiang Fu

12/18/2020, 9:13 PM
I think there is a recent change on this BatchConfigProperties
that was some refactoring there
b

balci

12/18/2020, 9:20 PM
Plain rebase didn’t seem to fix the problem. I guess I need to do some refactoring on my test
x

Xiang Fu

12/18/2020, 9:26 PM
sure
also have you tried to rebuild pinot from root?
mvn clean install -DskipTests
b

balci

12/18/2020, 9:27 PM
Not this time, but I just pushed with the change (refactored the test) and it seems to have passed the point of the compilation failure!
x

Xiang Fu

12/18/2020, 9:28 PM
😛
b

balci

12/18/2020, 9:29 PM
Thanks for the help Xiang! But I’m curious why my test picks up a newer version of the pinot-spi package, rather than what exists in my commit. Is it due to github-actions setup?
x

Xiang Fu

12/18/2020, 9:31 PM
I think this is for PR
yes github-action
the build may tries to rebase i guess
b

balci

12/18/2020, 9:42 PM
I see. I’ll see if there is an easy way to make those builds isolated.
Also can you please take a look at this (somewhat related) two liner quick fix: https://github.com/apache/incubator-pinot/pull/6370
🚢 1