https://pinot.apache.org/ logo
a

Aaron Wishnick

06/10/2021, 4:35 PM
I'm seeing that pinot-admin.sh will error out but not return a nonzero return code, e.g. when data ingestion job specs are malformed
m

Mayank

06/10/2021, 4:42 PM
Should be a simple fix? Care to file a PR?
a

Aaron Wishnick

06/10/2021, 4:48 PM
Sure!
m

Mayank

06/10/2021, 4:48 PM
thankyou
m

Mayank

06/10/2021, 4:53 PM
Oh, this is an issue. Did you also want to file a PR for the fix?
a

Aaron Wishnick

06/10/2021, 4:57 PM
I don't have a fix 😄
s

Subbu Subramaniam

06/10/2021, 5:09 PM
@Aaron Wishnick have you tried setting the system property
pinot.admin.system.exit
to
true
?
a

Aaron Wishnick

06/10/2021, 5:10 PM
Oh I haven't, didn't know that was a thing
Like, in JAVA_OPTS?
s

Subbu Subramaniam

06/10/2021, 5:11 PM
I think it is via java opts. We look at it as
System.getProperty()
m

Mayank

06/10/2021, 5:11 PM
Oh yea I vaguely remember why we did this:
Copy code
"-Xms4G -Xmx4G -Dpinot.admin.system.exit=true"
a

Aaron Wishnick

06/10/2021, 5:12 PM
Great, I'll try that. Thank you!
m

Mayank

06/10/2021, 5:12 PM
Update the issue?
s

Subbu Subramaniam

06/10/2021, 5:18 PM
@Aaron Wishnick did that work?
a

Aaron Wishnick

06/10/2021, 5:20 PM
Trying now