Apache Pinot

if so, there was some code added to the PinotAdministrator that has it do a `System.exit(0)` as soon as commands have been executed

<@UDQU92KBK> I chatted with <@UGRJA9TEH> about this. I'm gonna do a PR so that it'll not `System.exit(0)` for 'long running commands' while still exiting cleanly for other commands. <@UGRJA9TEH> did already add an exception for the QuickStartCommand, but we need it for a few others too (e.g. StartBroker, StartController, etc)

<@U01DS9A0DS4> does 0.9.0 has an issue then?

Are Docker containers part of the 0.9.0 release? I hadn’t thought they were (didn’t see anything about testing with Docker as part of validating a PR).

I think there are folks who may be starting pinot components using pinot-admin (not using docker). But if that has an exception, then we should be ok

<@U01DS9A0DS4> - the change was to set the system exit flag to true by default, when the pinot admin tool is built (in the pom.xml). The other code changes in `PinotAdministrator` were just to add missing sets for the _status flag.

<@UDQU92KBK> - ouch, sorry…didn’t realize people were using the pinot admin tool to launch persistent Pinot components. If so, then I should have added that to the release note. It would probably be worthwhile for me to enhance the docs in any case.

<@U01ECR21TEE> got it. I think that change works great for commands that run and then exit e.g. AddTableCommand, DeleteClusterCommand. But then for other commands (QuickStartCommand, StartBrokerCommand, etc) they need to be left running

<@U01DS9A0DS4> - right, so a reasonable fix would be to have an implicit flag value for every command, and the ability to override it using the existing system property.

I see ,in this case, let’s modify the doc meanwhile, patch the flags for long running subcommands

I can work on the patch flags PR tomorrow morning UK. I'll do that unless one of you beats me to it :slightly_smiling_face:

<@UGRJA9TEH> by patch you mean patching 0.9.1? I feel docs might not prevent the issue.

if it’s docker image, I can modify the ENV_VAR to make it with `-Dpinot.admin.system.exit=false` by default

for pinot-admin.sh, we can modify the docs to add the instruction

<@U01DS9A0DS4> did you get around to this? If not, I’d like to fix the problem that I introduced, as a way of making amends :disappointed:

Xiang has sorted it I think - <https://github.com/apache/pinot/pull/7798>