Apache Pinot

When query Pinot via Trino (362), the avg() function doesn’t seem to work correctly. It always returns no data…

Do you see any error anywhere in the logs? `logs/pinot-all.log` on each of the components.

Might be worth creating a GitHub issue if you have an easy way that someone else can reproduce/debug - <https://github.com/apache/pinot/issues>

Opened <https://github.com/trinodb/trino/issues/10148|https://github.com/trinodb/trino/issues/10148> last night

Seems to be an issue with the pinot connector in Trino

Question <@U022ZD8NEF3> - can you paste the table schema? I wanted to see if there are multiple columns which are the same when case is ignored

other aggregates like max, min, count work

Does the column which does not work contain uppercase characters?

seems this is what is missing in the implementation of avg: <https://github.com/trinodb/trino/blob/master/plugin/trino-pinot/src/main/java/io/trino/plugin/pinot/query/aggregation/ImplementMinMax.java#L66-L67>

omg - I have that locally (we use trino connector in prod) but I need to put that into one of the open pr's I have :facepalm: I will do this tonight, latest tomorrow. Thanks for catching this <@U022ZD8NEF3>, apologies for the issue.

There are a few other fixes in the 2 open pr's I have as well, will get them to you - hopefully will be in the latest release (trino 365)

Trying to push everything I have so that open source == what we have.

Ok, updated <https://github.com/trinodb/trino/pull/9781>

The last commit fixes the issue. Also found that it affects approx_distinct as well. Thanks for catching this <@U022ZD8NEF3>!