Hey everyone. I’m running the RealtimeToOfflineSeg...
# troubleshootingl
Lars-Kristian Svenøy
01/11/2022, 3:08 PMHey everyone. I’m running the RealtimeToOfflineSegmentsTask on some large tables, and unfortunately some of these tasks take longer than 1 hour to complete, triggering the timeout. Is the minion task timeout configurable?
Lars-Kristian Svenøy
01/11/2022, 3:08 PMIt looks like it’s hardcoded at 1 hour
m
Mayank
01/11/2022, 8:29 PM
@Xiaobing ^^
x
Xiaobing
01/11/2022, 8:32 PMhey @Lars-Kristian Svenøy, thanks for looking into this. Do you have a pointer to the hard coded 1hr timeout?
l
Lars-Kristian Svenøy
01/11/2022, 8:32 PMYes
Lars-Kristian Svenøy
01/11/2022, 8:32 PMGive me a second
👍 1
Lars-Kristian Svenøy
01/11/2022, 8:34 PMhttps://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotTaskManager.java#L422
https://github.com/apache/pinot/blob/master/pinot-controller/src/main/java/org/apa[…]/controller/helix/core/minion/generator/PinotTaskGenerator.java
https://github.com/apache/pinot/blob/master/pinot-plugins/pinot-minion-tasks/pinot[…]metoofflinesegments/RealtimeToOfflineSegmentsTaskGenerator.java does not override the default timeout, meaning it’s hardcoded to the default
👀 1
Lars-Kristian Svenøy
01/11/2022, 8:35 PMWould be nice if the getTaskTimeoutMs ditched the default signature, and forced implementors to implement configuration properties (which could default to 1hr if not provided of course)
Lars-Kristian Svenøy
01/11/2022, 8:36 PMThe current timeout makes this task useless for my larger tables.
Lars-Kristian Svenøy
01/11/2022, 8:36 PMI would make the change myself… 🙂 but I’m stuck in the middle of a deadline
x
Xiaobing
01/11/2022, 8:40 PMGot it. Would you mind open an issue about this?
l
Lars-Kristian Svenøy
01/11/2022, 8:40 PMYes can do
👍 1
Lars-Kristian Svenøy
01/11/2022, 8:47 PM