This message was deleted.
# dev
s
This message was deleted.
g
@Xavier has been doing a bunch of looking into this
you can read about the adventure on https://github.com/apache/druid/pull/12032
i think where things are at now is there are some funny test issues related to memory pooling
m
nice okay ill start digging
x
There’s a bunch of new MSQ code that needs to be ported to Netty 4 too :)
Mostly the new mock clients for testing.
m
MSQ code that needs to be ported to Netty 4
if you point me in the right direction I can get started
k
MSQTestBase is the class where all the stuff happens.
Copy code
/**
 * Base test runner for running MSQ unit tests. It sets up multi stage query execution environment
 * and populates data for the datasources. The runner does not go via the HTTP layer for communication between the
 * various MSQ processes.
 *
 * Controller -> Coordinator (Coordinator is mocked)
 *
 * In the Ut's we go from:
 * {@link MSQTaskQueryMaker} -> {@link MSQTestOverlordServiceClient} -> {@link Controller}
 *
 *
 * Controller -> Worker communication happens in {@link MSQTestControllerContext}
 *
 * Worker -> Controller communication happens in {@link MSQTestControllerClient}
 *
 * Controller -> Overlord communication happens in {@link MSQTestTaskActionClient}
That should be a good start
👍 2
x
I updated https://github.com/apache/druid/pull/12032 so all the code compiles and unit tests pass.
still seeing various new failures, and some OOM issues in some integration tests
@Karan Kumar are you still looking into helping out with this?
k
Just saw this thread. @Xavier What kind of help do you need ?