This message was deleted Apache Druid #dev

Join Slack

This message was deleted.

# dev

Slackbot

10/29/2022, 4:11 PM

This message was deleted.

kfaraz

10/30/2022, 5:11 AM

Thanks for the reminder, @Didip Kerabat. Will try to take a look this week.

👍 1

Abhishek Agarwal

10/31/2022, 12:22 PM

@Didip Kerabat the PR looks good to me for the most part though I don't follow the examples in the docs. I have posted the comments in the PR itself

Didip Kerabat

10/31/2022, 4:53 PM

Fixed the two incorrect documentations.

Gian Merlino

11/01/2022, 12:35 AM

my comments are also 100% doc related at this point -- the rest lgtm

Gian Merlino

11/01/2022, 12:35 AM

https://github.com/apache/druid/pull/13027#pullrequestreview-1162701634

Didip Kerabat

11/03/2022, 1:28 AM

@Gian Merlino Addressed! I got an unrelated Overlord timeout issue.

Abhishek Agarwal

11/03/2022, 8:21 AM

@Didip Kerabat - some examples use

**

objectGlob

and some use

. e.g. there is

**.parquet

and there is also

*.json

. I might be missing something.

Didip Kerabat

11/03/2022, 2:53 PM

Checking… I thought I searched and replaced everything

Gian Merlino

11/03/2022, 4:02 PM

I too see a lot of

"objectGlob": "*.json"

remaining in the docs, these should all be

"objectGlob": "**.json"

Abhishek Agarwal

11/03/2022, 4:04 PM

Thanks, Didip. While you are at it, can you also check if the description of

objectGlob

is same across all examples?

Didip Kerabat

11/05/2022, 5:31 AM

@Abhishek Agarwal I believe I took cared of everything now

Didip Kerabat

11/07/2022, 3:43 AM

@Abhishek Agarwal @Gian Merlino I think I fixed all the docs now.

Abhishek Agarwal

11/07/2022, 6:47 AM

thanks. I approved the PR.

❤️ 1

2 Views

Open in Slack

Previous Next