Hi Team, Please review this <PR> to add the functi...
# general
s
Hi Team, Please review this PR to add the functionality of kafka header based filtering. Thanks
k
This seems cool. We will get to it soon.
Could you please add a embedded test for the PR.
✅ 1
That would help in making this feature future proof.
s
@Karan Kumar, I have added an embedded test. Please take a look. TIA!
@Karan Kumar, gentle reminder to get this PR reviewed.
bumping this up!
k
Hey I can probably get to it next week.
👍 1
s
Hey @Karan Kumar, We have done load testing for this feature as well and wanted to deploy it on production clusters. Could you please take a look at this PR.
k
Left an initial review.
Thanks for the patience.
s
Thanks @Karan Kumar, replied to your comments. Let me know your thoughts.
Hey, Addressed your comments to rename the config back to
headerBasedFilterConfig
Could you please take a look and approve github workflows
@Frank Chen, @Karan Kumar, I have addressed most of the comments. Could you please re-review. Thanks..
Gentle reminder on this!
Gentle reminder on this!
k
Thanks for the reminder. Would plan to merge this post thanksgiving week
👍 1
s
FYI, We have deployed this feature on our prod clusters and ingestion pipeline is running smoothly with reduced CPU usage on indexers.