Hi folks, please review this PR to upgrade pac4j e...
# general
a
Hi folks, please review this PR to upgrade pac4j extension: https://github.com/apache/druid/pull/18259 This major upgrade is needed to fix CVE-2023-52428 which requires upgrading nimbus-jose-jwt to
9.37.2
which is not compatible with pac4j v4.
Hey @Lucas Capistrant, I have updated the PR as per your comment. Can you please help with re-running the flaky tests as mentioned in my reply? Thanks
@Lucas Capistrant - merged master as recommended and the flaky tests passed. Now only two checks are failing. One due to vulnerabilities in web-console (saw an open PR for its fix) and the other due to
use of a potentially broken or risky cryptographic algorithm
- but my PR has not updated the algo. We are using the same lago as earlier.
Hey, one check on my PR is failing due to the use of a potentially broken or risky cryptographic algorithm in
processing/src/main/java/org/apache/druid/crypto/CryptoService.java
. I have only made changes to pac4j extension in this PR and didn't change the algorithm and fixing this unrelated check will require significant change and testing in the other module. How can I get my PR merged in such a scenario?
The PR has been reviewed and approved. Can we please merge it now? Thanks