Hey all,
Can I get some reviews on my PR for attempting to fix multiple checkpoint issue during Kafka replicated ingestion, please ?
a
Amatya Avadhanula
04/10/2024, 9:27 AM
Hi Sadananda
Thank you for the PR. I had a doubt / suggestion about moving the isCheckpointed check to the if condition rather than the body of the block
Amatya Avadhanula
04/10/2024, 9:28 AM
Also, have you seen if it is possible to write a failing test to KafkaIndexTaskTest or a similar test class?
s
Sadananda Aithal
04/10/2024, 9:31 AM
Thanks for the review @Amatya Avadhanula
I’m incorporating that change as we speak in the PR.
Sure, I’ll work on adding a failing test case to KafkaIndexTaskTest.