Hey all, Can I get some reviews on my <PR> for at...
# general
s
Hey all, Can I get some reviews on my PR for attempting to fix multiple checkpoint issue during Kafka replicated ingestion, please ?
a
Hi Sadananda Thank you for the PR. I had a doubt / suggestion about moving the isCheckpointed check to the if condition rather than the body of the block
Also, have you seen if it is possible to write a failing test to KafkaIndexTaskTest or a similar test class?
s
Thanks for the review @Amatya Avadhanula I’m incorporating that change as we speak in the PR. Sure, I’ll work on adding a failing test case to KafkaIndexTaskTest.
a
Thanks!