This message was deleted Apache Druid #general

Join Slack

This message was deleted.

# general

Slackbot

02/01/2024, 11:28 AM

This message was deleted.

Rohan Garg

02/01/2024, 3:48 PM

Hey Fabrice!

AzureCloudBlobIterableFactory

is currently created via guice (through

FactoryModuleBuilder

https://google.github.io/guice/api-docs/3.0/javadoc/com/google/inject/assistedinject/FactoryModuleBuilder.html)

Rohan Garg

02/01/2024, 3:50 PM

From what I understand, guice just creates an implicit factory through the provided interface (in this case

AzureCloudBlobIterableFactory

). If you see, the

create

method contains all the parameters needed to construct

AzureCloudBlobIterable

- so the automatically created factory just uses the parameters to create an

AzureCloudBlobIterable

object. If you don't want to use guice, you can create a factory manually which just creates new

AzureCloudBlobIterable

objects given the

create

parameters

Rohan Garg

02/01/2024, 3:50 PM

Does the help?

Fabrice Baranski

02/01/2024, 4:13 PM

Thanks @Rohan Garg can you give me an example of implementation of your last suggestion? I am completely lost

Rohan Garg

02/01/2024, 6:43 PM

sure! I was thinking something like :

Copy code

class MyAzureCloudBlobIterableFactory {
  AzureCloudBlobIteratorFactory azureCloudBlobIteratorFactory; // have this as a member variable in the factory

  AzureCloudBlobIterable create(Iterable<URI> prefixes, int maxListingLength, AzureStorage azureStorage) {
    return new AzureCloudBlobIterable(azureCloudBlobIteratorFactory, prefixes, maxListingLength, azureStorage);
  }
}

guice is also doing something like this implicitly. does that make sense?

Fabrice Baranski

02/02/2024, 12:31 PM

Thanks it works!

👍 1

Open in Slack

Previous Next