This message was deleted.
# generals
Slackbot
10/17/2023, 4:53 PMThis message was deleted.
s
Sergio Ferragut
10/17/2023, 5:40 PMWhat's the issue number?
g
Gengwu Zhao
10/17/2023, 5:41 PMthe issue number is #15164
s
Sergio Ferragut
10/17/2023, 5:46 PMLooks like a good cleanup refactor. So yes, please submit a PR.
g
Gengwu Zhao
10/17/2023, 5:48 PMThank you very much.
Gengwu Zhao
10/17/2023, 5:48 PMAlso I have a few other refactoring very similar to this issue. Can I also just submit PRs or do I still need to create an issue first.
Gengwu Zhao
10/17/2023, 5:57 PMI've submitted a PR, number #15187.
s
Sergio Ferragut
10/17/2023, 9:17 PMIf you are improving stuff, go for PRs. The PRs have discussions, so any comments or fixes to your work should come out of those discussions.
g
Gengwu Zhao
10/19/2023, 1:14 PMHi, I noticed the progress in Github is ready to merge. do I need to do anything more.
s
Sergio Ferragut
10/19/2023, 4:54 PMIt will need get reviewed by project committers first. I suggest you edit the description in the PR and review and mark the checklist at the bottom. You want to make life as easy as possible for reviewers. You can then post the link to the PR in the the #C030CMF6B70 channel where more potential reviewers hang out and ask for a review.
g
Gengwu Zhao
10/19/2023, 5:25 PMYour suggestions are very useful! Thanks.
Gengwu Zhao
10/19/2023, 9:55 PMI refactored another file using the same method as issue#15164 and submitted PR#15217. If you're interested you can take a look.