This message was deleted.
# generals
Slackbot
07/03/2023, 7:43 PMThis message was deleted.
s
Suneet Saldanha
07/03/2023, 8:00 PMThanks for the contribution! I've kicked off the tests
🙏 1
a
Abhishek Agarwal
07/04/2023, 5:11 AM@Jan Werner - can you please look into license check failures?
👀 1
j
Jan Werner
07/04/2023, 3:16 PM@Abhishek Agarwal @Suneet Saldanha
Fixed the licenses. Can you please re-start the CI
a
Abhishek Agarwal
07/05/2023, 2:49 AMHmm. it's still failing
j
Jan Werner
07/05/2023, 4:34 AMI added some extra cleanup. local Rat-check went through OK
a
Abhishek Agarwal
07/05/2023, 6:55 AMrat-check checks for headers etc but license checks require one to run a different script
j
Jan Werner
07/05/2023, 3:38 PMI adressed all the issues that CI raised, what should I run to test it locally ?
a
Abhishek Agarwal
07/05/2023, 4:24 PMAbhishek Agarwal
07/05/2023, 4:24 PM./.github/scripts/license_checks_script.sh
🙏 1
j
Jan Werner
07/06/2023, 2:47 AMlicenses fixed up, I'm still getting an error with kubernetes-extension and bouncycastle even though the licenses are present in the licenses.yaml file
Jan Werner
07/06/2023, 2:47 AMpushed the latest correction and I'm a bit stumped
a
Abhishek Agarwal
07/06/2023, 6:53 AMI think whats happening is that the version 1.70 is being interpreted as number and is being passed around as
1.71.70Abhishek Agarwal
07/06/2023, 6:54 AMyou can try putting the
1.70j
Jan Werner
07/06/2023, 1:51 PMquotes did it
Jan Werner
07/06/2023, 1:51 PMI will fix the licensing tool in another PR
a
Abhishek Agarwal
07/06/2023, 1:51 PM👍
j
Jan Werner
07/06/2023, 1:51 PMcan you please kick of CI/CD
a
Abhishek Agarwal
07/06/2023, 1:52 PMdone
j
Jan Werner
07/06/2023, 1:52 PMawesome, thank you!
Jan Werner
07/06/2023, 3:30 PMha, no rest for the wicked, failure on used, undeclared dependency. fixed that one, testing locally mvn dependency:analyze, then licenses, this is taking a while 🙂
Jan Werner
07/06/2023, 5:13 PM@Abhishek Agarwal
fixed the used / undeclared dependency issue static check should finally pass 🤞
Jan Werner
07/07/2023, 2:42 PMthank you for the review, will you be able to merge it as well?
a
Abhishek Agarwal
07/07/2023, 2:57 PMDone
🙏 1
j
Jan Werner
07/07/2023, 3:03 PMyay my first druid contribution 🙂
Jan Werner
07/07/2023, 3:04 PMas minor as it is, makes me happy to give back a bit to the community
a
Abhishek Agarwal
07/07/2023, 3:04 PMthank you, Jan. It's not minor. Looking forward to seeing more contributions 🙂
j
Jan Werner
07/07/2023, 3:06 PMopened two issues as a roadmap of what I would like to do next:
https://github.com/apache/druid/issues/14551
https://github.com/apache/druid/issues/14550
those will require some more work 🙂
Jan Werner
07/07/2023, 3:06 PMthank you for guiding me through the process
a
Abhishek Agarwal
07/07/2023, 3:32 PMNice.