This message was deleted.
# dev
s
This message was deleted.
g
for me, the biggest issues are: • tests taking a long time • tests being flaky
c
in my experience i usually have tests passing way before i can get someone to actually review stuff, so i’m going to go with ‘finding someone to review’
not to say tests don’t need improvement, especially with regards to selectively running stuff based on the changes
a
For tests, one potential improvement we can make is to run tests that are absolutely needed. Like if changes are in MSQ extension only, a lot of tests can be skipped right away.
d
• The TravisCI feedback cycle is too long. • There needs to be an automatic default maven flags when running
mvn test
locally. It’s a bit demoralizing seeing so many failing tests when you don’t know which tests to turn off. • Here’s one that’s rarely mentioned. For those who are not familiar with Google Guice, the ramp up time to learn it is quite steep (in combination with Druid source code itself).
h
@Abhishek Agarwal, as a beginner who's trying to start contributing • I'm not able to find what issue to start, as they are not being labelled as
starters
recently. Picking up an issue becomes confusing for me, as a starter I want to pick up some small issues to understand complete workflow first. • The contributing guide is a little messy, if there can be a single development guide for complete workflow on how to set up, test changes, and test benchmarks to finally push the changes. It would be really helpful for devs like me who have just started and never worked on large maven projects like druid. Speaking of this, if anyone has any resources or recommendations for me, that can help me contribute more effectively, please share. Thanks in advance!
a
thank you for the feedback, Hardik and Didip. Btw we have moved away from TravisCI to Github actions. The feedback cycle is still not where I would want it to be. With Travis, the queue time for build is less but overall build time is still high. I am also working on tracking our issues better. First step in that direction is to enable stale bot so that the noise gets reduced.
@Hardik Bajaj If you are looking to make a contribution, you can pick up https://apachedruidworkspace.slack.com/archives/C030CMF6B70/p1680499388824519
I can help you get started and hopefully we can use your journey to also improve dev onboarding experience
h
Thanks @Abhishek Agarwal, I'll look into what you share
I can help you get started and hopefully we can use your journey to also improve dev onboarding experience
That sounds really good, I'd love to contribute to this too!
a
Echo some of the points here. Also adding one more recent pain point - the ability to not be able to run CI automatically when I open a PR or push commits as a contributor. Pinging a committer every time to do that seems like an overhead
(iirc @Clint Wylie was saying that this might be something Apache is gating, wonder what effort it’d take to remove this restriction?)
👍 1
g
I think we can raise a ticket with ASF Infra to change that so it goes back to running automatically for all PRs
a
That would be grand @Gian Merlino. Not sure if I can raise a ticket, can look into it end of week if nobody gets to it before 🙂