This message was deleted.
# dev
s
This message was deleted.
k
Hey Sergiu Thanks for starting this discussion. This is the correct forum for starting this. Yes I think druid as a project would benefit in moving to junit 5. Yes please open up an issue: https://github.com/apache/druid/issues and add more details as to how are you planning to migrate. Some points to think about: 1. Will it be a one shot migration as in you will completely remove junit 4 and move everything to junit 5. (it might be tough to review this) 2. If you one to migrate one module at a time, how would the migration look. If you can mention the advantages of junit 5 over junit 4 in the same issue, that would help give context to PR reviewers.
s
Hey Karan, Thank you for the response, I will come with a strategy for it and get back with an issue. My initial thought was to go with the second point but I haven't checked yet dependencies in between the tests, maybe rules ,or what else would be needed. In any case I will describe my thoughts in the issue.
Hey @Karan Kumar I already created a PR as suggested here is it possible to review it??
🙌 1
a
If you are looking to make more contributions, you can add a switch in SysMonitor to use
<https://github.com/oshi/oshi>
. Right now, SysMonitor uses Sigar which hasn't been upgraded in a while. And also doesn't work on ARM architecture machines.