Hi 👋 I’m thinking of extending the BambooHR source connector to support the custom report endpoint. The main complexity I see is that the endpoint takes a POST request with a list of fields, and returns only those fields. Has something like this already been implemented in another connector? One solution would be to add this list of field as a property in

spec.json

, and use that in the request. Maybe there’s a better way 🤷

Hi @Oliver Meyer, if the field names are custom, providing these in the

spec.json

is the way to go indeed.

👍 I’ll take a shot at it then, thanks!

If you want to make

POST

requests you need to set an

http_method = "POST"

in your stream's class.

is there a reason you can’t just ask for all fields?

is there a reason you can’t just ask for all fields by default?

Not sure I get it. You mean ask for all fields in the request? If that’s what you mean, then by design the endpoint is made to return only specific fields and that’s how we want to use it

just that it’s arduous for the user to input field by field what they want to get. If there is no API cost, it’s probably better to by default show them all the fields and once https://github.com/airbytehq/airbyte/issues/2227 is implemented, they can just choose which columns they want

Perhaps it could be optional - in terms of effort, I think I’d rather input 10 fields manually, than sort through 552 fields downstream

@Oliver Meyer, are you mentioning these fields?

Those are the default fields in BambooHR, but users can add as many custom fields as they want and they will all appear in the

discover

step

Ok then what do you think of always retrieving all the default fields + allowing users to add the name of their custom fields in the

spec.json

?

I’m still not sure that should be the expected behaviour. By design this endpoint is made to pull only specific fields from Bamboo (see the doc). If I give the connector a list of 5 fields I want, and it returns 85 fields instead (there are 80 default fields), I would say that’s more of a bug than a feature

It depends on the wording 😄 Something like internal custom fields with a good description would allow users with this use case to add their fields and others to always have a default custom report filled with data. Do you know if the Bamboo API rates is impacted by the number of requested fields?

Can’t say, I’m not familiar with their rate limiting

All right, feel free to go with the approach you prefer and we'll keep the fine-tuning session during PR reviews. Thanks for considering contributing😄!

Sounds good I’ll take a shot and see what happens