Hello,
I have opened this <PR> on Airbyte for Sour...
# help-connector-developmentm
Mariam Thiam
11/30/2022, 9:41 AMHello,
I have opened this PR on Airbyte for Source Amplitude to resolve issue #19605 to enable data server region selection.
Can someone give a review on it ? 🙏
Thanks
m
Marcos Marx (Airbyte)
11/30/2022, 11:45 AMI left some comments, sorry the delay Mariam
m
Mariam Thiam
12/01/2022, 12:10 PMThanks for the review @Marcos Marx (Airbyte), I have update the PR!
Mariam Thiam
12/06/2022, 9:14 AMHello @Marcos Marx (Airbyte),
I’m still need your review on this PR. I have updated the code bases on your comment.
Mariam Thiam
12/07/2022, 4:46 PMI have just fixed integration test based on my changes. If you can retake a look it will be great.
Thanks
m
Marcos Marx (Airbyte)
12/07/2022, 4:51 PMOh totally sorry Mariam
Marcos Marx (Airbyte)
12/07/2022, 4:51 PMI’ll take a look rn
m
Mariam Thiam
12/07/2022, 4:51 PMThanks 🙏
Mariam Thiam
12/09/2022, 10:20 AMI don’t understand what is the integration’s test issues that occurred after the branch update with master 🤔 . I can’t reproduce them locally.
m
Marcos Marx (Airbyte)
12/09/2022, 1:19 PM@Mariam Thiam I’ll take a look about the issue!
👍 1
5 Views