This content can't be displayed.
# oss-master-build-failure
u
This content can't be displayed.
p
fyi @Benoit Moriceau (Airbyte) looks like https://github.com/airbytehq/airbyte/pull/12586 broke the build for connectors base (there are some files in the CDK that are generated from the protocol yaml file)
👀 1
b
I am not sure about what I shoudl do here to fix the test. I am seeing that HubspotOAuthFlowTest is failing. How does this is related to the protocol?
p
sorry, this build specifically also had a different issue that was fixed on another commit. if you take a look at later commits they're failing because of the protocol update (e.g. https://github.com/airbytehq/airbyte/runs/6414242636?check_suite_focus=true)
i just pushed up the change to fix here https://github.com/airbytehq/airbyte/pull/12829
b
👍 Is there something I should have done before to noticed it?
p
Seems like the Connectors Base build wasn't triggered on that PR, so it's easy to miss... but in general updating the protocol will require re-generating the protocol file for the CDK as well
Maybe updating that yaml file should trigger it
b
Seems like the Connectors Base build wasn't triggered on that PR, so it's easy to miss... but in general updating the protocol will require re-generating the protocol file for the CDK as well
I'll keep that in mind for future update. I agree that it should have trigger the build.