This content can t be displayed | Oss-master-build-failure

This is the PR that broke the build on master. I now have several tasks failing in CONNECTORS_BASE build because they cannot find the files that were deleted or moved in that PR

👀 1

7:07 PM

I’ve pinged @Mykyta Serbynevskyi [GL]on Slack as well just now

👍 1

user

07/11/2022, 7:08 PM

we can probably revert this while i look if this is blocking the path to production. that said i'm just looking now

7:15 PM

my initial impression is that i can find/replace this in about an hour. assuming my expectations around document generation are accurate

7:16 PM

it looks like some tests and some document generation use hardcoded paths to things we moved. I believe that fixing those will address this

Greg Solovyev (Airbyte)

07/11/2022, 7:20 PM

Thank you for looking into this!

👍 1

user

07/11/2022, 7:42 PM

@Greg Solovyev (Airbyte) you need to read the commit message for the line i just fixed for when it was committed almost exactly a year ago https://github.com/airbytehq/airbyte/pull/5080

😆 1

7:42 PM

how long does this integration test take anyway, i think i have the bug fixed i'm just watching the test suite now

Greg Solovyev (Airbyte)

07/11/2022, 8:07 PM

deja vu

8:22 PM

there is another build failure related to the same change (it failed on CI on your PR just now)

8:22 PM

chown: /airbyte/docs/integrations/*: No such file or directory

is the problem

user

07/11/2022, 8:24 PM

just an update: the docs team doesn't like the changes overall anyway so we are reverting them wholesale

😮ctavia-hmm: 1

8:24 PM

Amruta is double checking the revert and we'll get it up there

8:25 PM

it's sad, but better now that 100 commits later

8:38 PM

i think if you pull you should be set now greg

👀 1

8:52 PM

~~i take it back greg, there is a new new failure that appears docs related~~ i think it's actually green and i was looking at a tab from cloud. give me a yell if i'm wrong

Greg Solovyev (Airbyte)

07/11/2022, 9:12 PM

yep, build on master just worked locally

👍 1

9:13 PM

@User Topher just fixed builds on master and I think that affects your feature branch for validating JDBC params, so you may want to rebase on master and push to your branch again

👍🏽 1

user

07/11/2022, 9:17 PM

Thanks for heads up, I'll be sure to incorporate the changes into my branch. Just to clarify if there are some builds that are failing, would this channel be the right place to ask?

Greg Solovyev (Airbyte)

07/11/2022, 9:19 PM

Usually, #dev channel is better for these questions. In this case I found the PR that broke the build and started a thread from the automated notification of that build failure

👍🏽 1

View count: 2

Join thread in Slack