This content can't be displayed.
# oss-master-build-failure
u
This content can't be displayed.
g
@User I think doc generation changes broke the build in several places. It’s breaking now for me locally as well.
This is the PR that broke the build on master. I now have several tasks failing in CONNECTORS_BASE build because they cannot find the files that were deleted or moved in that PR
πŸ‘€ 1
I’ve pinged @Mykyta Serbynevskyi [GL]on Slack as well just now
πŸ‘ 1
u
we can probably revert this while i look if this is blocking the path to production. that said i'm just looking now
u
my initial impression is that i can find/replace this in about an hour. assuming my expectations around document generation are accurate
u
it looks like some tests and some document generation use hardcoded paths to things we moved. I believe that fixing those will address this
g
Thank you for looking into this!
πŸ‘ 1
u
@Greg Solovyev (Airbyte) you need to read the commit message for the line i just fixed for when it was committed almost exactly a year ago https://github.com/airbytehq/airbyte/pull/5080
πŸ˜† 1
u
how long does this integration test take anyway, i think i have the bug fixed i'm just watching the test suite now
g
deja vu
there is another build failure related to the same change (it failed on CI on your PR just now)
chown: /airbyte/docs/integrations/*: No such file or directory
is the problem
u
just an update: the docs team doesn't like the changes overall anyway so we are reverting them wholesale
πŸ€” 1
u
Amruta is double checking the revert and we'll get it up there
u
it's sad, but better now that 100 commits later
u
i think if you pull you should be set now greg
πŸ‘€ 1
u
i take it back greg, there is a new new failure that appears docs related i think it's actually green and i was looking at a tab from cloud. give me a yell if i'm wrong
g
yep, build on master just worked locally
πŸ‘ 1
@User Topher just fixed builds on master and I think that affects your feature branch for validating JDBC params, so you may want to rebase on master and push to your branch again
πŸ‘πŸ½ 1
u
Thanks for heads up, I'll be sure to incorporate the changes into my branch. Just to clarify if there are some builds that are failing, would this channel be the right place to ask?
g
Usually, #dev channel is better for these questions. In this case I found the PR that broke the build and started a thread from the automated notification of that build failure
πŸ‘πŸ½ 1