https://linen.dev logo
a

Artem Astapenko

03/23/2021, 9:23 PM
or we assume that we support all of sync modes right now?
c

Chris (deprecated profile)

03/24/2021, 9:28 AM
yes or we base it on if the destination has normalization enabled or not
a

Artem Astapenko

03/24/2021, 1:43 PM
Well FE doesn’t know whether it supports normalization or not. So should we assume that all 3 modes for destination are supported then?
c

Chris (deprecated profile)

03/24/2021, 1:47 PM
in the FE, you don’t check if destination has
supportsIncremental
in their specs to
true
in order to set incremental on the source/sync too?
(seems like all our destination has
Copy code
supportsIncremental = true
anyway…
But from FE, you can’t inspect the spec.json returned from the destination to change the options available in the UI?
a

Artem Astapenko

03/24/2021, 1:56 PM
No. We have a field supportedSyncModes and it returns them.
And in case of destination if we do not support some modes then it should be somehow told in the UI
c

Chris (deprecated profile)

03/24/2021, 2:00 PM
Ok, so the BE would need to add some
destinationSupportedSyncMode
on the connection objects or somewhere to inform what’s possible or not with this combination of source/destination connectors
I’ll open a new issue for that,.. for the moment, you can assume all modes are supported?
a

Artem Astapenko

03/24/2021, 2:40 PM
let me just clarify 1 thing: so from frontend we send syncMode and destinationSyncmode, but as we have 1 one dropdown we are actually selecting 2 enums, thats why I need to know all possible mappings we support. According to what Charles posted, we want to display full_refresh -> overwrite, incremental -> append, incremental -> append_dedup. Theoretically we should have cartesian product of this modes displayed, but I and Charles decided that we have only 3 now. so we should have then
full_refresh append
and
incremental overwrite
too?
c

Chris (deprecated profile)

03/24/2021, 2:42 PM
Just adding
full_refresh append
because we have a user case from a user not
incremental overwrite
because we’re not sure if that’s useful yet
in the FE, if you can make sure to have some links to the documentation page (
docs/architecture/connections.md
for example) where we can detail more about what the dropdown will map to and the expected behavior should be
a

Artem Astapenko

03/24/2021, 3:01 PM
Ok. Sure
c

Chris (deprecated profile)

03/24/2021, 3:09 PM
Thanks!
3 Views