I just want to flag here something that's not nece...
# replication-connector-contributions
c
I just want to flag here something that's not necessarily for my specific contribution/PR for this platform, but more of a loophole in how contributions are handled/reviewed. Several weeks ago, the Facebook Pages connector broke because it was not compatible with the latest versions of the API and is returning an "Error: Bad request" message (see #63718 and #66509) Take note that this connector is a Marketplace connector, and we all fully understand that it's up to the community to maintain/fix these connectors. Hence there was a PR that was made to fix that, from the community: https://github.com/airbytehq/airbyte/pull/66536 Unfortunately it sat for an extended period of time in review purgatory, and was just eventually closed. Why was it closed? Because there was, I assume, a PR deployed to update that connector from an Airbyte Team member: https://github.com/airbytehq/airbyte/pull/69714 Yet that PR did not fix the problem at all -- when trying to set up that Facebook Pages connector as a source, the "Bad request" error still persists (see screenshot). Escalating this issue to support -- since the deployed PR was made presumably by an Airbyte Team member -- only returns a canned response about how Marketplace connectors aren't maintained by Airbyte themselves (see screenshot #2). This, despite the fact that the latest update came from the Airbyte team. So it's kinda frustrating to see how a community PR -- a potential fix for this specific issue -- just get swept under the rug, to be replaced by an Airbyte Team PR that doesn't solve the problem. I hope this situation gets resolved soon, both in terms of the issue with the connector AND who should be responsible for their PRs. It can get discouraging to try and contribute to a project, and on a broader scale, continue using a platform when there are no guarantees about what reliably continues to work.
💯 2
k
Hi @Clara Buenconsejo, Thanks for flagging this! I definitely understand your frustration. We have made some recent changes to our Contribution Guidelines to try to ease the process, namely contributors will now automatically be asked to sign our CLA and ensure that branches are writable by Airbyte maintainers. This cuts back on a lot of back and forth for version bumps etc. We have also made it easier for our team to run tests directly on contributor branches. Although Facebook Pages is a Marketplace Connector, the Airbyte team does occasionally hop in an make modifications, as you noted in: https://github.com/airbytehq/airbyte/pull/69714 . Over the last few days, I have had the opportunity to take a closer look: • Upon seeing your screenshots, I noticed that the documentation was still referencing v15 of the API even though that Airbyte PR changed the reference to v24 (the community PR was using v23). I pushed an update to make sure the docs were accurate on 11/27. • I also compared the community PR to the Airbyte PR for additional gaps. ◦ This new PR fixes the pagination parameter name and limit. ◦ This other new PR aims to provide better error messaging for the 400 errors on the
page
stream and also removes the
page
stream from our check operation. â—¦ _FYI we have asked Meta for an additional catalog_management scope with advanced access._ Please let me know if the issue persists!