I have recently opened a PR to introduce a new sou...
# replication-connector-contributions
f
I have recently opened a PR to introduce a new source connector for chift. Here is the link to the PR - https://github.com/airbytehq/airbyte/pull/67707 Question: How can I apply format checks? The commands I used for that no longer seem to exist :
airbyte-ci connectors --name=source-chift check
airbyte-ci connectors --name=source-chift format
i
Maintainers now run this with
/format-fix
. No need to do anything yet. It looks like this one is in the review queue.
šŸ™ 1
f
Ok great thanks!
Hello @Ian Alton, quick question - just making sure this PR is still in the review queue? The person that commented on the PR is not from the official airbyte team
Also, I did not manage to run:
airbyte-ci connectors --name=source-chift format-fix
- still got a command not found error
i
It's still in the queue, yeah. The format fix command can only be run by maintainers - I just ran it for you and will run connector tests too. I'll still need someone from the engineering team to review though. Sorry it's taking a while.
šŸ™ 1
f
Hello Ian, we had the same issue with this PR for example - https://github.com/airbytehq/airbyte/pull/38786 I would gladly share you edit access but I had this problem in another PR where I tried to follow (https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests) and think it is not possible due to the fact that my fork was created under an organization. Here is the link to the git discussion (#34166 (comment)). How should be proceed?
i
Ah OK. This is a GitHub permissions thing that has caused some issues. For this to work, I believe: • It needs to be a personal fork, not an organization • Airbyte maintainers need write access to the PR The problem is without this we can't run connector tests or fix formatting issues (as you can see). We've updated our contributor guidelines to reflect this requirement. I'm sorry to have to ask, but to proceed you'll need to recreate the PR from a personal fork. I know that's a pain but the team was running into this issue quite often and it had became a blocker for them too many times.
f
Hi @Ian Alton, I understand, I will re-create the PR today from a personal account and get back to you asap on this. Thanks
Hello @Ian Alton, as requested, please find the newly created Pull Request with maintainers access allowed - https://github.com/airbytehq/airbyte/pull/69198
i
Thanks for doing that.
If you can also please sign the Contributor License Agreement that will help move it along.
(link is in the PR)
f
Hello @Ian Alton, done, thanks and sorry for the delay
šŸ™ 1
Hi @Ian Alton, are there any actions on my side left on this PR? Thanks
i
It doesn't look like it. It should be in the reviewer's hands now.
šŸ™ 1
āœ… 1
f
Hello @Ian Alton, thanks for the merge! Any idea of when the officially merged chift source will be available in your terraform connector list?
i
We just have to generate a new version of the provider. It won't be until after the holidays though (we're trying to give on call people an uninterrupted break).
šŸ™ 1