It seems that `Airbyte CI / Connectors Base: Build...
# oss-master-build-failure
e
It seems that
Airbyte CI / Connectors Base: Build (push)
is consistently failing on Master. ๐Ÿงต
Maybe @Sherif Nada - any ideas?
s
https://github.com/airbytehq/airbyte/actions/runs/3277761497/jobs/5395417617#step:12:8884
Copy code
collecting ... 
	 โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€• ERROR collecting test_backward_compatibility.py โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•
	 unit_tests/test_backward_compatibility.py:998: in <module>
	     "test_stream": AirbyteStream.parse_obj(
	 pydantic/main.py:521: in pydantic.main.BaseModel.parse_obj
	     ???
	 pydantic/main.py:341: in pydantic.main.BaseModel.__init__
	     ???
	 E   pydantic.error_wrappers.ValidationError: 1 validation error for AirbyteStream
	 E   supported_sync_modes
	 E     field required (type=value_error.missing)
	 
	 โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€• ERROR collecting test_core.py โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•โ€•
	 unit_tests/test_core.py:125: in <module>
	     ???
	 pydantic/main.py:521: in pydantic.main.BaseModel.parse_obj
	     ???
	 pydantic/main.py:341: in pydantic.main.BaseModel.__init__
	     ???
	 E   pydantic.error_wrappers.ValidationError: 1 validation error for AirbyteStream
	 E   supported_sync_modes
	 E     field required (type=value_error.missing)
This looks related to the protocol changes @Augustin Lafanechere (Airbyte) was making?
g
I am seeing this today as well when running tests on bases/base-normalization
a
This should be resolved now that I merged the protocol change PR and the updated SAT unit tests are now on master
g
Do I need to rebase my PR to resolve this?
a
The root cause is the following: โ€ข I published a new version of the CDK from my branch โ€ข SAT unit tests on master installed this new CDK version as a dependency with updated models, but SAT instantiated invalid model according to the new CDK โ€ข The changes on SAT were made on my branch, it's merged to master now so it should be solved
Sorry for the inconvenience, it was quite tricky to figure the best way to orchestrate this change without breaking anything
e
Thanks @Augustin Lafanechere (Airbyte)! Can you share this note in #dev as well please
And yeah... that was a very tricky PR