We’ve written a patch to address a date formatting issue with the Netsuite source connector when attempting incremental updates. It seems we aren’t the only ones to have run into the problem. It appears that the input format of the date has changed from m/d/Y to Y-m-d. This assumption is based on the error message as the last time I checked, the documentation hadn’t caught up. Review on the PR has stalled because of a failing acceptance test. However, I cannot get the acceptance tests passing for this connector on the master branch. I’m getting 5 failures. I’m guessing that I’m missing some sort of precondition, but I have no idea what it might be. These are the failures:

======================================================================================================================================================================== short test summary info =========================================================================================================================================================================

FAILED ../../bases/source-acceptance-test/source_acceptance_test/tests/test_core.py:TestDiscovery:test_defined_refs_exist_in_schema[inputs0] - AssertionError: Found unresolved

$refs

values for selected streams: ({‘customrecord_advpromo_discount’: [‘/services/rest/record/v1/metadata-catalog/inventoryitem’, ’/services/rest/record/v1/metadata-catalog/assem...

FAILED ../../bases/source-acceptance-test/source_acceptance_test/tests/test_core.py:TestBasicRead:test_read[inputs0] - docker.errors.ContainerError: Command ‘read --config /data/tap_config.json --catalog /data/catalog.json’ in image ’<Image: ‘airbyte/source-netsuite:dev’>' returned non-zero exit status 1: {“type”: “TRACE”, “trace”: {“type”: “ERROR”, “emit...

FAILED ../../bases/source-acceptance-test/source_acceptance_test/tests/test_full_refresh.py:TestFullRefresh:test_sequential_reads[inputs0] - docker.errors.ContainerError: Command ‘read --config /data/tap_config.json --catalog /data/catalog.json’ in image ’<Image: ‘airbyte/source-netsuite:dev’>' returned non-zero exit status 1: {“type”: “TRACE”, “trace”: {...

FAILED ../../bases/source-acceptance-test/source_acceptance_test/tests/test_incremental.py:TestIncremental:test_two_sequential_reads[inputs0] - AssertionError: Should produce at least one record

FAILED ../../bases/source-acceptance-test/source_acceptance_test/tests/test_incremental.py:TestIncremental:test_read_sequential_slices[inputs0] - AssertionError: Should produce at least one record

Can anyone offer a suggestion how I might get these tests working so that I can look at the real failure on the branch? Thanks!

@[DEPRECATED] Marcos Marx turned this message into Zendesk ticket 2784 to ensure timely resolution!

Hi! Thank you for your patience, I am looking into why the acceptance tests are failing and hope to have some ideas for you tomorrow!

would be great to have this fix 🙏

Looks like there are some new comments for @Joe Swatosh on the PR and it's very close to being merged!

Yup, I’ve been following it closely 🥹