Hey folks - I've noticed Shopify syncs were succee...
# connector-contributions
k
Hey folks - I've noticed Shopify syncs were succeeding despite not all of the data being written. It looks like a simple oversight or a design decision. I've opened a 1 liner to update this but would appreciate a bit of feedback either way. Happy New Year! https://github.com/airbytehq/airbyte/pull/50976
u
Happy new year Keith!
I asked connector team to review your contribution. Please ping me if you need any update
k
Awesome - thank you
Thanks for the review Marcos 🙌 I just bumped the version numbers again as there was another shopify release since I opened the PR.
u
great im gonna merge it
k
Thanks again
Good morning @[DEPRECATED] Marcos Marx - There was failing tests on my PR which have now been resolved. Hopefully it's good to go now - I can't click through to all of the status checks so I'm a little bit blind if something else is not quite right. Thanks!
Hey @[DEPRECATED] Marcos Marx, just a polite bump on this - there are failing checks on the PR but I can't access any detail beyond when I click through. Thanks
u
I need to get tests fixed let me try this week to get this merged
k
Hey Marcos - sorry to nag. Can I get an update on this?