I’m using the latest 0.4.8

source-postgres

source and I have a problem where I’m not able to list any tables in my source even though my user is able to select from the tables. I see there are a couple relevant tickets. * https://github.com/airbytehq/airbyte/pull/9875 * https://github.com/airbytehq/airbyte/pull/10173 I debugged and found that in

AbstractJdbcSource.discoverInternal()

where it filters tables with

excludeNotAccessibleTables

protected Predicate<JsonNode> excludeNotAccessibleTables(final Set<String> internalSchemas,
                                                           final Set<JdbcPrivilegeDto> tablesWithSelectGrantPrivilege) {

the

tablesWithSelectGrantPrivilege

variable was empty. So because of that it entered this branch:

if (tablesWithSelectGrantPrivilege.isEmpty()) {
        return isNotInternalSchema(jsonNode, internalSchemas);
      }

and the

PostgresSource

has commented out the

isNotInternalSchema()

method to always filter out the

@Override
  protected boolean isNotInternalSchema(JsonNode jsonNode, Set<String> internalSchemas) {
    return false;
  }

If the

isNotInternalSchema

wasn’t overriden by postgres then my tables show up properly. I’m trying to understand the logic behind this? Whether the problem is with

getPrivilegesTableForCurrentUser

or that the

isNotInternalSchema

should not be overridden? Can someone shed some light on the philosophy behind how the

AbstractJdbcSource.excludeNotAccessibleTables

is supposed to work and the reasoning behind the

PostgresSource.isNotInternalSchema

overriding?

Created the issue here: https://github.com/airbytehq/airbyte/issues/10649