Nils de Bruin
07/22/2021, 2:44 PMuser
07/22/2021, 2:45 PMJeff Crooks
07/22/2021, 3:00 PMuser
07/22/2021, 3:01 PMuser
07/22/2021, 3:11 PMuser
07/22/2021, 3:11 PMuser
07/22/2021, 3:11 PMuser
07/22/2021, 3:12 PMJeff Crooks
07/22/2021, 3:12 PMuser
07/22/2021, 3:13 PMuser
07/22/2021, 3:14 PMuser
07/22/2021, 3:15 PMuser
07/22/2021, 3:16 PMuser
07/22/2021, 3:16 PMupdated_at
columns as the source defined column for incremental, the user woudn’t need to modify it (and set it to created_at
instead for example)?user
07/22/2021, 3:17 PMJeff Crooks
07/22/2021, 3:17 PMuser
07/22/2021, 3:18 PMuser
07/22/2021, 3:20 PMI’ll log a new issue for the stripe tables later todayThanks! that will make sure we can fix that wrong choice for the many users of that source too!
curious, whats the reasoning behind preventing a user from changing it?@s do you have a better answer maybe?
user
07/22/2021, 3:29 PMuser
07/22/2021, 3:30 PMJeff Crooks
07/22/2021, 4:18 PMcurious, whats the reasoning behind preventing a user from changing it?it’s a nontrivial footgun. First, not all fields are valid cursors. You can usually filter by created_at or sorted_at in an API, but not ID for example. There are also some invariants a cursor field must have that may not hold for other fields e.g: it must be comparable, it can’t be null, etc.. so allowing a user to configure it had some non trivial risk. Also, not all fields can be used as cursors. from a development standpoint, sources which can assume a certain cursor field will always be used are a little simpler than those which have to check which one was used, validate it, and use it etc. Neither of these is insurmountable, but given those issues, it wasn’t a big priority to do this. i like your idea of warning but letting user change anyways Would you be open to create a ticket expressing this?
user
07/22/2021, 4:22 PMuser
07/22/2021, 6:13 PM