can someone remind me why we are doing both of these steps in the master build?

- name: Build
        run: ./gradlew build --no-daemon -g ${{ env.GRADLE_PATH }}

and

- name: Build Core Docker Images (Master branch only)
        if: success() && github.ref == 'refs/heads/master'
        run: docker-compose -f docker-compose.build.yaml build

isn’t the latter a super set of the former?

the docker build is slower than calling gradle directly

Makes sense. But why are we we doing both in the same github action?

the important part is that the latter builds the docker images for running acceptance tests

and only runs on master

Could we not run the build step on master? And just do the docker compose build?

we could but we'd have to wait the extra however many minutes to get feedback on whether the unit tests/core build succeeded (which is the operation we do more commonly on branches)

it'll probably add ~3-4 minutes

the idea is that we don't want to slow iteration time on PRs to build docker images, run integration tests etc.. at the cost of once we merge to master we'll take the longer build time

I feel like we are talking about different things.

I'm just talking about master.

oh so you're saying why not skip the earlier build step if we're in master?

Exactly.

we can totally do that 😛