https://linen.dev logo
#contributing-to-airbyte
Title
# contributing-to-airbyte
c

charles

09/11/2020, 4:27 PM
@s is there anything i can do to help on the “it works” front?
u

user

09/11/2020, 4:41 PM
• Work with Artem to resolve his build issues • Write an e2e test case for a scheduled sync (right now we only have manual sync)
u

user

09/11/2020, 4:41 PM
cc @Michel since you were asking about this
u

user

09/11/2020, 4:42 PM
The latest on postgres is right now we don't support incremental sync in our singer taps (ifaces do but impl doesn't account for it in a few places). That's the last remaining piece in postgres which then unblocks remaining e2e tests
u

user

09/11/2020, 4:44 PM
impl as in the singer impl?
u

user

09/11/2020, 4:45 PM
our data type is missing a key needed by singer (replication-key) and the type conversions don't account for it
u

user

09/11/2020, 4:45 PM
@charles is replication-key input anywhere in the UI when setting up incremental sync?
u

user

09/11/2020, 4:46 PM
no
u

user

09/11/2020, 4:46 PM
aren’t just doing full refresh and append for MVP?
u

user

09/11/2020, 4:46 PM
is replication key needed for append?
u

user

09/11/2020, 4:46 PM
I thought we were just doing append
u

user

09/11/2020, 4:47 PM
there's at least one point in the code where append was hard coded
u

user

09/11/2020, 4:47 PM
you’re probably right.
u

user

09/11/2020, 4:47 PM
the operative thing here is whether you need repication-key for append.
u

user

09/11/2020, 4:48 PM
yeah
u

user

09/11/2020, 4:48 PM
yes
u

user

09/11/2020, 4:48 PM
singer only has
FULL_REFRESH
and
INCREMENTAL
u

user

09/11/2020, 4:48 PM
whelp. we have a problem then.
u

user

09/11/2020, 4:48 PM
the spec at least
u

user

09/11/2020, 4:49 PM
how is replication key specified in singer? in the catalog?
u

user

09/11/2020, 4:49 PM
yes
u

user

09/11/2020, 4:49 PM
right next to where it specifies replication method
u

user

09/11/2020, 4:50 PM
do you want to zoom about this real quick