Channels
#contributing-to-airbyte
Title
# contributing-to-airbyte
c
charles
09/18/2020, 4:22 PM
it looks like there’s been a regression on the postgres tap. i’m looking into it.
u
user
09/18/2020, 4:24 PMWhat do you mean? And how did you discover it? Are the tests not catching something they should?
u
user
09/18/2020, 4:25 PMa few things wrong
• i dataline cannot connect to my heroku database that i can connect to from the command line.
• it says connection successful but it is not
• no schema is fetched.
u
user
09/18/2020, 4:26 PMit is possible an issue specific to how heorku configures users in their database.
u
user
09/18/2020, 4:31 PMtracking here https://github.com/datalineio/dataline/issues/339
u
user
09/18/2020, 4:39 PMweird. it worked for harry on a heroku db yesterday
u
user
09/18/2020, 4:41 PMas source or target?
u
user
09/18/2020, 4:42 PMsource
u
user
09/18/2020, 4:42 PMohh
u
user
09/18/2020, 4:42 PMhmm
u
user
09/18/2020, 4:42 PMactually only target
u
user
09/18/2020, 4:42 PMwe were going to use source and switched
u
user
09/18/2020, 4:42 PMnvm
u
user
09/18/2020, 4:42 PMkk
u
user
09/18/2020, 4:43 PMdodged a bullet 😅
u
user
09/18/2020, 4:43 PM:)
u
user
09/18/2020, 4:52 PMu
user
09/18/2020, 4:52 PMyou mind rubberstamping this?
u
user
09/18/2020, 4:52 PMi forgot to bump the version on the source 🤦♀️ 🤦♀️ 🤦♀️ 🤦♀️ 🤦♀️ 🤦♀️
u
user
09/18/2020, 4:52 PMxD
u
user
09/18/2020, 5:02 PMdumb question, wouldn’t not bumping the version be okay as long as we build/publish the images?
u
user
09/18/2020, 5:02 PM“be okay” meaning changes should get picked up