https://linen.dev logo
Join Slack
Powered by
master build started failing. it had been successf...
# contributing-to-airbyte
c
master build started failing. it had been successful on the last commit, but when the build re-ran on the same commit it failed. have meetings starting now, but can take a look after.
u
@Jared Rhizor (Airbyte) I think you mentioned you understood what was going on here. Is it something you're fixing or should I go ahead and take a look after lunch ?
u
I’m fixing the operational problem that led to this build failing. It should be easier for you to work on the actual build failure though
u
u
🤯 🤯 🤯 🤯 🤯
u
hahah wow
u
what i’m confused about is that this commit is removing this check.
u
so i guess it means we’re using an old version on github?
u
and some version changed today.
u
…or something.
u
Can we just create the path if it doesn't exist in the acceptance script then? That seems like the desired behavior ultimately.
u
so yes, we can do that.
u
i’m worried that the “wow” of just doing docker compose up will be ruined though.
u
at this point i’m not too worried about the acceptanc test, i want to make sure it doesn’t spoil testing out our app though.
u
oh ok, so the worry is that others will fail locally
u
like do we need to add mkdir -p /tmp/airbyte_local to your docs.
u
hmm
u
yeah
u
yeah ok that is worse
u
what version of docker are you on?
u
but the check was removed 😢
u
yeah.
u
19.03.12
u
i’m confused about that part
u
and docker compose?
u
docker-compose version 1.26.2, build eefe0d31
u
Copy code
➜  airbyte git:(cgardens/fix_build2) ✗ docker --version
Docker version 19.03.12, build 48a66213fe
➜  airbyte git:(cgardens/fix_build2) ✗ docker-compose --version
docker-compose version 1.27.2, build 18f557f9
u
so neither of our versions of docker compose have this issue.
u
going to try to figure out what version github is running.
u
I think if the lastest versions of docker/docker-compose don't have this issue we should just add something temporarily for the github build to succeed
u
agreed.
u
do you know how git CI gets docker?
u
I was just looking
u
I don't know
u
kk
u
i’ll figure it out
u
we could add docker version to the workflow
u
and docker-compose version
u
just so we know
u
👍
u
u
ubuntu-latest
u
1.27.2 -> 1.27.3 overnight it looks like
u
where do you see the change overnight?
u
this commit is 4 days ago?
u
u
i was looking at that. isn’t that just a lift and shift?
u
the github action version readme was updated 7hr ago
u
u
the commit prior to it wasn't a lift and shift
u
and that was also jut introduced
u
👌
u
beautiful
u
alright so there are a couple versions where you have to create the directory
u
but that's only if you've updated/installed docker compose over a week period
u
I'm fine just telling people to upgrade if they run into this issue.
u
yeah.
u
essentiall it’s 1.27.3 is no good.
u
yep
u
and if you’re on 1.27.4 upgrade to the newest version
u
1.27.4 is the newest
u
if you're not on 1.27.4 upgrade?
u
oh. these were pushed as hotfixes
u
like you could have pulled a version of 1.27.4 that would not work.
u
but if you repull now it should be okay?
u
i can’t find a way to use an old version of these github virtual envs, so for now, i’m just going to stick the mkdir in their and call it a day.
u
ah ok
u
wait why do you mean it's a hotfix
u
u
looks like it made it into the 1.27.4 release?
u
Sticking in the mkdir seems fine. Maybe with a todo so we can delete it when 
ubuntu-latest
upgrades?
u
you’re right. i was confused by how some of the other commits were tagged.
Open in Slack
PreviousNext
Powered by