https://linen.dev logo
#contributing-to-airbyte
Title
# contributing-to-airbyte
c

charles

09/24/2020, 5:56 PM
master build started failing. it had been successful on the last commit, but when the build re-ran on the same commit it failed. have meetings starting now, but can take a look after.
u

user

09/24/2020, 7:09 PM
@Jared Rhizor (Airbyte) I think you mentioned you understood what was going on here. Is it something you're fixing or should I go ahead and take a look after lunch ?
u

user

09/24/2020, 7:11 PM
I’m fixing the operational problem that led to this build failing. It should be easier for you to work on the actual build failure though
u

user

09/24/2020, 9:24 PM
🤯 🤯 🤯 🤯 🤯
u

user

09/24/2020, 9:26 PM
hahah wow
u

user

09/24/2020, 9:26 PM
what i’m confused about is that this commit is removing this check.
u

user

09/24/2020, 9:26 PM
so i guess it means we’re using an old version on github?
u

user

09/24/2020, 9:27 PM
and some version changed today.
u

user

09/24/2020, 9:27 PM
…or something.
u

user

09/24/2020, 9:32 PM
Can we just create the path if it doesn't exist in the acceptance script then? That seems like the desired behavior ultimately.
u

user

09/24/2020, 9:32 PM
so yes, we can do that.
u

user

09/24/2020, 9:32 PM
i’m worried that the “wow” of just doing docker compose up will be ruined though.
u

user

09/24/2020, 9:33 PM
at this point i’m not too worried about the acceptanc test, i want to make sure it doesn’t spoil testing out our app though.
u

user

09/24/2020, 9:33 PM
oh ok, so the worry is that others will fail locally
u

user

09/24/2020, 9:33 PM
like do we need to add mkdir -p /tmp/airbyte_local to your docs.
u

user

09/24/2020, 9:33 PM
hmm
u

user

09/24/2020, 9:33 PM
yeah
u

user

09/24/2020, 9:33 PM
yeah ok that is worse
u

user

09/24/2020, 9:33 PM
what version of docker are you on?
u

user

09/24/2020, 9:33 PM
but the check was removed 😢
u

user

09/24/2020, 9:33 PM
yeah.
u

user

09/24/2020, 9:33 PM
19.03.12
u

user

09/24/2020, 9:33 PM
i’m confused about that part
u

user

09/24/2020, 9:34 PM
and docker compose?
u

user

09/24/2020, 9:34 PM
docker-compose version 1.26.2, build eefe0d31
u

user

09/24/2020, 9:34 PM
Copy code
➜  airbyte git:(cgardens/fix_build2) ✗ docker --version
Docker version 19.03.12, build 48a66213fe
➜  airbyte git:(cgardens/fix_build2) ✗ docker-compose --version
docker-compose version 1.27.2, build 18f557f9
u

user

09/24/2020, 9:34 PM
so neither of our versions of docker compose have this issue.
u

user

09/24/2020, 9:34 PM
going to try to figure out what version github is running.
u

user

09/24/2020, 9:34 PM
I think if the lastest versions of docker/docker-compose don't have this issue we should just add something temporarily for the github build to succeed
u

user

09/24/2020, 9:35 PM
agreed.
u

user

09/24/2020, 9:35 PM
do you know how git CI gets docker?
u

user

09/24/2020, 9:35 PM
I was just looking
u

user

09/24/2020, 9:35 PM
I don't know
u

user

09/24/2020, 9:36 PM
kk
u

user

09/24/2020, 9:36 PM
i’ll figure it out
u

user

09/24/2020, 9:36 PM
we could add docker version to the workflow
u

user

09/24/2020, 9:36 PM
and docker-compose version
u

user

09/24/2020, 9:36 PM
just so we know
u

user

09/24/2020, 9:36 PM
👍
u

user

09/24/2020, 9:38 PM
ubuntu-latest
u

user

09/24/2020, 9:39 PM
1.27.2 -> 1.27.3 overnight it looks like
u

user

09/24/2020, 9:40 PM
where do you see the change overnight?
u

user

09/24/2020, 9:40 PM
this commit is 4 days ago?
u

user

09/24/2020, 9:42 PM
i was looking at that. isn’t that just a lift and shift?
u

user

09/24/2020, 9:42 PM
the github action version readme was updated 7hr ago
u

user

09/24/2020, 9:43 PM
the commit prior to it wasn't a lift and shift
u

user

09/24/2020, 9:43 PM
and that was also jut introduced
u

user

09/24/2020, 9:43 PM
👌
u

user

09/24/2020, 9:43 PM
beautiful
u

user

09/24/2020, 9:43 PM
alright so there are a couple versions where you have to create the directory
u

user

09/24/2020, 9:44 PM
but that's only if you've updated/installed docker compose over a week period
u

user

09/24/2020, 9:44 PM
I'm fine just telling people to upgrade if they run into this issue.
u

user

09/24/2020, 9:44 PM
yeah.
u

user

09/24/2020, 9:45 PM
essentiall it’s 1.27.3 is no good.
u

user

09/24/2020, 9:45 PM
yep
u

user

09/24/2020, 9:45 PM
and if you’re on 1.27.4 upgrade to the newest version
u

user

09/24/2020, 9:45 PM
1.27.4 is the newest
u

user

09/24/2020, 9:45 PM
if you're not on 1.27.4 upgrade?
u

user

09/24/2020, 9:46 PM
oh. these were pushed as hotfixes
u

user

09/24/2020, 9:46 PM
like you could have pulled a version of 1.27.4 that would not work.
u

user

09/24/2020, 9:46 PM
but if you repull now it should be okay?
u

user

09/24/2020, 9:47 PM
i can’t find a way to use an old version of these github virtual envs, so for now, i’m just going to stick the mkdir in their and call it a day.
u

user

09/24/2020, 9:48 PM
ah ok
u

user

09/24/2020, 9:49 PM
wait why do you mean it's a hotfix
u

user

09/24/2020, 9:49 PM
looks like it made it into the 1.27.4 release?
u

user

09/24/2020, 9:50 PM
Sticking in the mkdir seems fine. Maybe with a todo so we can delete it when
ubuntu-latest
upgrades?
u

user

09/24/2020, 9:50 PM
you’re right. i was confused by how some of the other commits were tagged.