https://linen.dev logo
j

Jared Rhizor (Airbyte)

10/16/2020, 7:28 PM
Should we commit generate type files to Git?
u

user

10/16/2020, 7:28 PM
tu or td
u

user

10/16/2020, 7:28 PM
this is for both python and java
u

user

10/16/2020, 7:28 PM
In general I would say no
u

user

10/16/2020, 7:28 PM
it should be consistent.
u

user

10/16/2020, 7:28 PM
Why not?
u

user

10/16/2020, 7:29 PM
It requires
./gradlew build
to run before IDEs won't complain
u

user

10/16/2020, 7:29 PM
you never have diffs on generation settings-level changes
u

user

10/16/2020, 7:30 PM
also for new people looking at the repo they don't see implementations of our entire data model, which is confusing
u

user

10/16/2020, 7:31 PM
I just see generated code as one more place whre you can break the build
u

user

10/16/2020, 7:31 PM
The downside is just a little bit more effort for merge commits when there are data model changes? Maybe confusion over if the files are editable?
u

user

10/16/2020, 7:31 PM
in a way that you don't notice
u

user

10/16/2020, 7:31 PM
the merge piece is a big deal
u

user

10/16/2020, 7:31 PM
as well as diff
u

user

10/16/2020, 7:31 PM
I don't really think so, can just clean and regenerate in the event of the merge commit
u

user

10/16/2020, 7:32 PM
I would argue that the diff is desirable
u

user

10/16/2020, 7:32 PM
I am fine if for now for python we commit the generated code because we don't have a great process
u

user

10/16/2020, 7:32 PM
Especially since we have some custom override logic for Java
u

user

10/16/2020, 7:33 PM
In the middle of fixing master. We can discuss it later
3 Views