Should we commit generate type files to Git?

tu or td

this is for both python and java

In general I would say no

it should be consistent.

Why not?

It requires

./gradlew build

to run before IDEs won't complain

you never have diffs on generation settings-level changes

also for new people looking at the repo they don't see implementations of our entire data model, which is confusing

I just see generated code as one more place whre you can break the build

The downside is just a little bit more effort for merge commits when there are data model changes? Maybe confusion over if the files are editable?

in a way that you don't notice

the merge piece is a big deal

as well as diff

I don't really think so, can just clean and regenerate in the event of the merge commit

I would argue that the diff is desirable

I am fine if for now for python we commit the generated code because we don't have a great process

Especially since we have some custom override logic for Java

In the middle of fixing master. We can discuss it later