Channels
j
Jared Rhizor (Airbyte)
10/19/2020, 5:12 PM
Is anyone working on the build?
u
user
10/19/2020, 5:12 PM@s saw you reference it in #dev-frontend, not sure if you were looking into it
u
user
10/19/2020, 5:13 PMit’s about to succeed on master
u
user
10/19/2020, 5:13 PMbut it's failing on all branches?
u
user
10/19/2020, 5:13 PMbut in general it’s been really wonky
u
user
10/19/2020, 5:13 PMyeah
u
user
10/19/2020, 5:13 PMit works locally for me
u
user
10/19/2020, 5:13 PMsame here, but it fails non deterministically on branches
u
user
10/19/2020, 5:14 PMit's failing on exchange rate which is the simplest of tests
u
user
10/19/2020, 5:14 PMright so I fixed that by adding more “days” in the test’s lookback window
u
user
10/19/2020, 5:14 PMthat was kind of a hack in my branch
u
user
10/19/2020, 5:14 PMthat branch isn't in master yet, right?
u
user
10/19/2020, 5:14 PMno
u
user
10/19/2020, 5:14 PMmaster just succeeded
u
user
10/19/2020, 5:15 PMnow it started failing on postgres (the thing I’m working on) in a way that doesn’t happen locally for me. So i’m looking into it there
u
user
10/19/2020, 5:17 PMdo you think that'll be in soon? if not, I'll put up a PR to merge in your days change just so I can start merging some of my other PRs.
u
user
10/19/2020, 5:20 PMYou should add it
u
user
10/19/2020, 5:20 PMtakes 2 mins
u
user
10/19/2020, 5:20 PMbut that doesn’t really fix the issue because it only fails on branches
u
user
10/19/2020, 5:21 PMmaster succeeds without the change
u
user
10/19/2020, 5:21 PMI initially added it because I thought master hadn’t built in a while
u
user
10/19/2020, 5:22 PMtu
u
user
10/19/2020, 5:25 PMrubber stamp? https://github.com/airbytehq/airbyte/pull/622
u
user
10/19/2020, 5:25 PMrubber stamped
u
user
10/19/2020, 5:25 PMthanks
u
user
10/19/2020, 5:26 PMwhy does this fix things?
u
user
10/19/2020, 5:27 PMat the very least it tells us why it breaks
u
user
10/19/2020, 5:27 PMis thre just no exchange rate info over the weekend?
u
user
10/19/2020, 5:27 PMnot sure why additional days are needed on branches only
u
user
10/19/2020, 5:27 PMmaybe
u
user
10/19/2020, 5:27 PMhuh. if it’s a there’s only data from week days issue then this makes sense.
u
user
10/19/2020, 5:28 PMmight also be why it started working if they published a new one at some point this mornign?
u
user
10/19/2020, 5:28 PMlet me check
u
user
10/19/2020, 5:31 PMconfirmed