Is anyone working on the build?
# contributing-to-airbyte
j
Is anyone working on the build?
u
@s saw you reference it in #dev-frontend, not sure if you were looking into it
u
it’s about to succeed on master
u
but it's failing on all branches?
u
but in general it’s been really wonky
u
yeah
u
it works locally for me
u
same here, but it fails non deterministically on branches
u
it's failing on exchange rate which is the simplest of tests
u
right so I fixed that by adding more “days” in the test’s lookback window
u
that was kind of a hack in my branch
u
that branch isn't in master yet, right?
u
no
u
master just succeeded
u
now it started failing on postgres (the thing I’m working on) in a way that doesn’t happen locally for me. So i’m looking into it there
u
do you think that'll be in soon? if not, I'll put up a PR to merge in your days change just so I can start merging some of my other PRs.
u
You should add it
u
takes 2 mins
u
but that doesn’t really fix the issue because it only fails on branches
u
master succeeds without the change
u
I initially added it because I thought master hadn’t built in a while
u
tu
u
u
rubber stamped
u
thanks
u
why does this fix things?
u
at the very least it tells us why it breaks
u
is thre just no exchange rate info over the weekend?
u
not sure why additional days are needed on branches only
u
maybe
u
huh. if it’s a there’s only data from week days issue then this makes sense.
u
might also be why it started working if they published a new one at some point this mornign?
u
let me check
u
confirmed