https://linen.dev logo
j

Jared Rhizor (Airbyte)

10/19/2020, 5:12 PM
Is anyone working on the build?
u

user

10/19/2020, 5:12 PM
@s saw you reference it in #dev-frontend, not sure if you were looking into it
u

user

10/19/2020, 5:13 PM
it’s about to succeed on master
u

user

10/19/2020, 5:13 PM
but it's failing on all branches?
u

user

10/19/2020, 5:13 PM
but in general it’s been really wonky
u

user

10/19/2020, 5:13 PM
yeah
u

user

10/19/2020, 5:13 PM
it works locally for me
u

user

10/19/2020, 5:13 PM
same here, but it fails non deterministically on branches
u

user

10/19/2020, 5:14 PM
it's failing on exchange rate which is the simplest of tests
u

user

10/19/2020, 5:14 PM
right so I fixed that by adding more “days” in the test’s lookback window
u

user

10/19/2020, 5:14 PM
that was kind of a hack in my branch
u

user

10/19/2020, 5:14 PM
that branch isn't in master yet, right?
u

user

10/19/2020, 5:14 PM
no
u

user

10/19/2020, 5:14 PM
master just succeeded
u

user

10/19/2020, 5:15 PM
now it started failing on postgres (the thing I’m working on) in a way that doesn’t happen locally for me. So i’m looking into it there
u

user

10/19/2020, 5:17 PM
do you think that'll be in soon? if not, I'll put up a PR to merge in your days change just so I can start merging some of my other PRs.
u

user

10/19/2020, 5:20 PM
You should add it
u

user

10/19/2020, 5:20 PM
takes 2 mins
u

user

10/19/2020, 5:20 PM
but that doesn’t really fix the issue because it only fails on branches
u

user

10/19/2020, 5:21 PM
master succeeds without the change
u

user

10/19/2020, 5:21 PM
I initially added it because I thought master hadn’t built in a while
u

user

10/19/2020, 5:22 PM
tu
u

user

10/19/2020, 5:25 PM
u

user

10/19/2020, 5:25 PM
rubber stamped
u

user

10/19/2020, 5:25 PM
thanks
u

user

10/19/2020, 5:26 PM
why does this fix things?
u

user

10/19/2020, 5:27 PM
at the very least it tells us why it breaks
u

user

10/19/2020, 5:27 PM
is thre just no exchange rate info over the weekend?
u

user

10/19/2020, 5:27 PM
not sure why additional days are needed on branches only
u

user

10/19/2020, 5:27 PM
maybe
u

user

10/19/2020, 5:27 PM
huh. if it’s a there’s only data from week days issue then this makes sense.
u

user

10/19/2020, 5:28 PM
might also be why it started working if they published a new one at some point this mornign?
u

user

10/19/2020, 5:28 PM
let me check
u

user

10/19/2020, 5:31 PM
confirmed