is mypy supposed to catch import statements that a...
# contributing-to-airbytec
charles
10/28/2020, 3:03 PM
is mypy supposed to catch import statements that are wrong, right (e.g. trying to import a class that does not exist in the specified module)
u
user
10/28/2020, 3:07 PMit'll try to typecheck so probably would fail i guess yes?
u
user
10/28/2020, 3:07 PMhuh. okay.
u
user
10/28/2020, 3:08 PMImportError: cannot import name 'Source' from 'airbyte_protocol'u
user
10/28/2020, 3:08 PMi’m getting errors like this at runtime.
u
user
10/28/2020, 3:08 PMwhich seems like it shouldn’t happen.
u
user
10/28/2020, 3:08 PMseems like they shoudl be caught in the compile step.
u
user
10/28/2020, 3:08 PMor mypy step.
u
user
10/28/2020, 3:11 PMi guess if the dependency isn’t loaded onto the docker image properly it might pass mypy step though but fail at runtime.
u
user
10/28/2020, 3:14 PMnope. ignore my last.